add serial plotter reset command

Author: Alberto Iannaccone

arduino-ide-extension/src/browser/monitor-manager-proxy-client-impl.ts

@@ -12,6 +12,7 @@ import {
 } from '../node/monitor-settings/monitor-settings-provider';
 import { BoardsConfig } from './boards/boards-config';
 import { MonitorViewContribution } from './serial/monitor/monitor-view-contribution';
+import { SerialPlotterContribution } from './serial/plotter/plotter-frontend-contribution';
 
 @injectable()
 export class MonitorManagerProxyClientImpl
@@ -109,10 +110,14 @@ export class MonitorManagerProxyClientImpl
     if (
       board.fqbn !== this.lastConnectedBoard?.selectedBoard?.fqbn ||
       port.id !== this.lastConnectedBoard?.selectedPort?.id
-    )
+    ) {
       await this.commandRegistry.executeCommand(
         MonitorViewContribution.RESET_SERIAL_MONITOR
       );
+      await this.commandRegistry.executeCommand(
+        SerialPlotterContribution.Commands.RESET.id
+      );
+    }
     this.lastConnectedBoard = {
       selectedBoard: board,
       selectedPort: port,

arduino-ide-extension/src/browser/serial/plotter/plotter-frontend-contribution.ts

@@ -23,6 +23,11 @@ export namespace SerialPlotterContribution {
       label: 'Serial Plotter',
       category: 'Arduino',
     };
+    export const RESET: Command = {
+      id: 'serial-plotter-reset',
+      label: 'Reset Serial Plotter',
+      category: 'Arduino',
+    };
   }
 }
 
@@ -59,6 +64,9 @@ export class PlotterFrontendContribution extends Contribution {
     registry.registerCommand(SerialPlotterContribution.Commands.OPEN, {
       execute: this.startPlotter.bind(this),
     });
+    registry.registerCommand(SerialPlotterContribution.Commands.RESET, {
+      execute: () => this.reset(),
+    });
   }
 
   registerMenus(menus: MenuModelRegistry): void {
@@ -96,28 +104,9 @@ export class PlotterFrontendContribution extends Contribution {
   }
 
   protected async open(wsPort: number): Promise<void> {
-    const board = this.boardsServiceProvider.boardsConfig.selectedBoard;
-    const port = this.boardsServiceProvider.boardsConfig.selectedPort;
-    let baudrates: number[] = [];
-    let currentBaudrate = -1;
-    if (board && port) {
-      const { pluggableMonitorSettings } =
-        await this.monitorManagerProxy.getCurrentSettings(board, port);
-      if (pluggableMonitorSettings && 'baudrate' in pluggableMonitorSettings) {
-        // Convert from string to numbers
-        baudrates = pluggableMonitorSettings['baudrate'].values.map((b) => +b);
-        currentBaudrate = +pluggableMonitorSettings['baudrate'].selectedValue;
-      }
-    }
-
     const initConfig: Partial<SerialPlotter.Config> = {
-      baudrates,
-      currentBaudrate,
-      currentLineEnding: this.model.lineEnding,
       darkTheme: this.themeService.getCurrentTheme().type === 'dark',
       wsPort,
-      interpolate: this.model.interpolate,
-      connected: this.model.connected,
       serialPort: this.model.serialPort,
     };
     const urlWithParams = queryString.stringifyUrl(
@@ -129,4 +118,11 @@ export class PlotterFrontendContribution extends Contribution {
     );
     this.window = window.open(urlWithParams, 'serialPlotter');
   }
+
+  protected async reset(): Promise<void> {
+    if (!!this.window) {
+      this.window.close();
+      await this.startPlotter();
+    }
+  }
 }