Skip to content

Commit 52dbc37

Browse files
author
Alberto Iannaccone
committed
fix board selection and workspace input dialogs width and height
1 parent 4e590ab commit 52dbc37

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

Diff for: arduino-ide-extension/src/browser/boards/boards-config-dialog.ts

+1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export class BoardsConfigDialog extends AbstractDialog<BoardsConfig.Config> {
3434
) {
3535
super({ ...props, maxWidth: 500 });
3636

37+
this.node.id = 'select-board-dialog-container';
3738
this.contentNode.classList.add('select-board-dialog');
3839
this.contentNode.appendChild(this.createDescription());
3940

Diff for: arduino-ide-extension/src/browser/style/boards-config-dialog.css

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
#select-board-dialog-container > .dialogBlock {
2+
width: 640px;
3+
height: 500px;
4+
}
5+
16
div#select-board-dialog {
27
margin: 5px;
38
}

Diff for: arduino-ide-extension/src/browser/style/dialogs.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
total = padding + margin = 96px
1010
*/
1111
max-width: calc(100% - 96px) !important;
12-
min-width: unset;
12+
13+
min-width: 424px;
1314
max-height: 560px;
1415
padding: 0 28px;
1516
}

Diff for: arduino-ide-extension/src/browser/theia/workspace/workspace-input-dialog.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ export class WorkspaceInputDialog extends TheiaWorkspaceInputDialog {
1414
constructor(
1515
@inject(WorkspaceInputDialogProps)
1616
protected override readonly props: WorkspaceInputDialogProps,
17-
@inject(LabelProvider) protected override readonly labelProvider: LabelProvider
17+
@inject(LabelProvider)
18+
protected override readonly labelProvider: LabelProvider
1819
) {
1920
super(props, labelProvider);
21+
this.node.classList.add('workspace-input-dialog');
2022
this.appendCloseButton(
2123
nls.localize('vscode/issueMainService/cancel', 'Cancel')
2224
);

0 commit comments

Comments
 (0)