Skip to content

Commit 516a48a

Browse files
committed
Fix board options not shown for manually installed platforms
1 parent 69ac1f4 commit 516a48a

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

Diff for: arduino-ide-extension/src/browser/boards/boards-data-store.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -238,13 +238,11 @@ export class BoardsDataStore implements FrontendApplicationContribution {
238238
if (!fqbn) {
239239
return undefined;
240240
}
241-
const boardsPackage = await this.boardsService.getContainerBoardPackage({
242-
fqbn,
243-
});
244-
if (!boardsPackage) {
241+
const boardDetails = await this.boardsService.getBoardDetails({ fqbn });
242+
if (!boardDetails) {
245243
return undefined;
246244
}
247-
return boardsPackage.installedVersion;
245+
return boardDetails.version;
248246
}
249247
}
250248

Diff for: arduino-ide-extension/src/common/protocol/boards-service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ export namespace InstalledBoardWithPackage {
261261

262262
export interface BoardDetails {
263263
readonly fqbn: string;
264+
readonly version: string;
264265
readonly requiredTools: Tool[];
265266
readonly configOptions: ConfigOption[];
266267
readonly programmers: Programmer[];

Diff for: arduino-ide-extension/src/node/boards-service-impl.ts

+4-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ import { InstallWithProgress } from './grpc-installable';
4545
@injectable()
4646
export class BoardsServiceImpl
4747
extends CoreClientAware
48-
implements BoardsService
49-
{
48+
implements BoardsService {
5049
@inject(ILogger)
5150
protected logger: ILogger;
5251

@@ -178,8 +177,11 @@ export class BoardsServiceImpl
178177
PID = prop.get('pid') || '';
179178
}
180179

180+
// This is the platform version this board belongs to
181+
const version = detailsResp.getVersion();
181182
return {
182183
fqbn,
184+
version,
183185
requiredTools,
184186
configOptions,
185187
programmers,

0 commit comments

Comments
 (0)