Skip to content

Commit 50cfe0d

Browse files
author
Akos Kitta
committed
Use the default Theia spinner.
Signed-off-by: Akos Kitta <[email protected]>
1 parent 1aa9e08 commit 50cfe0d

File tree

4 files changed

+1
-57
lines changed

4 files changed

+1
-57
lines changed

Diff for: arduino-ide-extension/src/browser/style/index.css

-18
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,3 @@ button.theia-button.main {
108108
.fa-reload {
109109
font-size: 14px;
110110
}
111-
112-
/* restore the old Theia spinner */
113-
/* https://github.com/eclipse-theia/theia/pull/10761#issuecomment-1131476318 */
114-
.old-theia-preload {
115-
position: absolute;
116-
top: 0;
117-
left: 0;
118-
right: 0;
119-
bottom: 0;
120-
z-index: 50000;
121-
background: var(--theia-editor-background);
122-
background-image: var(--theia-preloader);
123-
background-size: 60px 60px;
124-
background-repeat: no-repeat;
125-
background-attachment: fixed;
126-
background-position: center;
127-
transition: opacity 0.8s;
128-
}

Diff for: arduino-ide-extension/src/browser/theia/core/frontend-application.ts

-22
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,4 @@ export class FrontendApplication extends TheiaFrontendApplication {
3232
}
3333
});
3434
}
35-
36-
protected override getStartupIndicator(
37-
host: HTMLElement
38-
): HTMLElement | undefined {
39-
let startupElement = this.doGetStartupIndicator(host, 'old-theia-preload'); // https://github.com/eclipse-theia/theia/pull/10761#issuecomment-1131476318
40-
if (!startupElement) {
41-
startupElement = this.doGetStartupIndicator(host, 'theia-preload'); // We show the new Theia spinner in dev mode.
42-
}
43-
return startupElement;
44-
}
45-
46-
private doGetStartupIndicator(
47-
host: HTMLElement,
48-
classNames: string
49-
): HTMLElement | undefined {
50-
const elements = host.getElementsByClassName(classNames);
51-
const first = elements[0];
52-
if (first instanceof HTMLElement) {
53-
return first;
54-
}
55-
return undefined;
56-
}
5735
}

Diff for: electron/build/scripts/patch-theia-preload.js

-16
This file was deleted.

Diff for: electron/build/template-package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"package": "cross-env DEBUG=* && electron-builder --publish=never",
2424
"package:publish": "cross-env DEBUG=* && electron-builder --publish=always",
2525
"download:plugins": "theia download:plugins",
26-
"patch": "ncp ./patch/main.js ./src-gen/backend/main.js && node ./scripts/patch-theia-preload.js ./lib/index.html"
26+
"patch": "ncp ./patch/main.js ./src-gen/backend/main.js"
2727
},
2828
"engines": {
2929
"node": ">=14.0.0 <15"

0 commit comments

Comments
 (0)