refactor monitor commands protocol

Author: Alberto Iannaccone

arduino-ide-extension/src/browser/monitor-manager-proxy-client-impl.ts

@@ -111,7 +111,7 @@ export class MonitorManagerProxyClientImpl
 
     this.webSocket.send(
       JSON.stringify({
-        command: Monitor.Command.SEND_MESSAGE,
+        command: Monitor.ClientCommand.SEND_MESSAGE,
         data: message,
       })
     );
@@ -124,9 +124,7 @@ export class MonitorManagerProxyClientImpl
 
     this.webSocket.send(
       JSON.stringify({
-        command: Monitor.Command.CHANGE_SETTINGS,
-        // TODO: This might be wrong, verify if it works
-        // SPOILER: It doesn't
+        command: Monitor.ClientCommand.CHANGE_SETTINGS,
         data: settings,
       })
     );

arduino-ide-extension/src/common/protocol/monitor-service.ts

@@ -59,13 +59,18 @@ export interface PluggableMonitorSetting {
 }
 
 export namespace Monitor {
-  export enum Command {
-    SEND_MESSAGE = 'MONITOR_SEND_MESSAGE',
-    CHANGE_SETTINGS = 'MONITOR_CHANGE_SETTINGS',
+  // Commands sent by the clients to the web socket server
+  export enum ClientCommand {
+    SEND_MESSAGE = 'SEND_MESSAGE',
+    CHANGE_SETTINGS = 'CHANGE_SETTINGS',
+  }
+
+  export enum MiddlewareCommand {
+    ON_SETTINGS_DID_CHANGE = 'ON_SETTINGS_DID_CHANGE',
   }
 
   export type Message = {
-    command: Monitor.Command;
+    command: Monitor.ClientCommand;
     data: string | MonitorSettings;
   };
 }

arduino-ide-extension/src/node/monitor-service.ts

@@ -419,10 +419,10 @@ export class MonitorService extends CoreClientAware implements Disposable {
           const message: Monitor.Message = JSON.parse(msg);
 
           switch (message.command) {
-            case Monitor.Command.SEND_MESSAGE:
+            case Monitor.ClientCommand.SEND_MESSAGE:
               this.send(message.data as string);
               break;
-            case Monitor.Command.CHANGE_SETTINGS:
+            case Monitor.ClientCommand.CHANGE_SETTINGS:
               this.changeSettings(message.data as MonitorSettings);
               break;
           }