Added core when updating error onSelection change

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/contributions/compiler-errors.ts

@@ -335,20 +335,27 @@ export class CompilerErrors
     console.log(
       `Handling selection change in editor ${uri}. New (monaco) selection: ${monacoSelection.toJSON()}`
     );
-    const intersectsError = (
+    const calculatePriority = (
       candidateErrorRange: monaco.Range,
       currentSelection: monaco.Range
     ) => {
       console.trace(`Candidate error range: ${candidateErrorRange.toJSON()}`);
       console.trace(`Current selection range: ${currentSelection.toJSON()}`);
-      // if editor selection intersects with the error range or the selection is in one of the lines of an error.
-      const result =
-        candidateErrorRange.intersectRanges(currentSelection) ||
-        (candidateErrorRange.startLineNumber <=
+      if (candidateErrorRange.intersectRanges(currentSelection)) {
+        console.trace('Intersects.');
+        return { score: 2 };
+      }
+      if (
+        candidateErrorRange.startLineNumber <=
           currentSelection.startLineNumber &&
-          candidateErrorRange.endLineNumber >= currentSelection.endLineNumber);
-      console.trace(`Intersects: ${result}`);
-      return result;
+        candidateErrorRange.endLineNumber >= currentSelection.endLineNumber
+      ) {
+        console.trace('Same line.');
+        return { score: 1 };
+      }
+
+      console.trace('No match');
+      return undefined;
     };
     const error = (
       await Promise.all(
@@ -363,15 +370,18 @@ export class CompilerErrors
           .map(async ({ error, rangeOf }) => {
             const range = await rangeOf;
             if (range) {
-              if (intersectsError(range, monacoSelection)) {
-                return error;
+              const priority = calculatePriority(range, monacoSelection);
+              if (priority) {
+                return { ...priority, error };
               }
             }
             return undefined;
           })
       )
     )
       .filter(notEmpty)
+      .sort((left, right) => right.score - left.score) // highest first
+      .map(({ error }) => error)
       .shift();
     if (error) {
       this.markAsCurrentError(error);