avoid multiple notifications in different windows

Author: francescospissu

Diff for: arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

@@ -292,6 +292,10 @@ import { PreferenceTreeGenerator } from './theia/preferences/preference-tree-gen
 import { PreferenceTreeGenerator as TheiaPreferenceTreeGenerator } from '@theia/preferences/lib/browser/util/preference-tree-generator';
 import { AboutDialog } from './theia/core/about-dialog';
 import { AboutDialog as TheiaAboutDialog } from '@theia/core/lib/browser/about-dialog';
+import {
+  SurveyNotificationService,
+  SurveyNotificationServicePath,
+} from '../common/protocol/survey-service';
 
 MonacoThemingService.register({
   id: 'arduino-theme',
@@ -480,6 +484,15 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
   bind(SurveyNotification).toSelf().inSingletonScope();
   bind(FrontendApplicationContribution).toService(SurveyNotification);
 
+  bind(SurveyNotificationService)
+    .toDynamicValue((context) => {
+      return ElectronIpcConnectionProvider.createProxy(
+        context.container,
+        SurveyNotificationServicePath
+      );
+    })
+    .inSingletonScope();
+
   // Layout and shell customizations.
   rebind(TheiaOutlineViewContribution)
     .to(OutlineViewContribution)

Diff for: arduino-ide-extension/src/browser/contributions/survey-notification.ts

@@ -5,6 +5,7 @@ import { LocalStorageService } from '@theia/core/lib/browser';
 import { nls } from '@theia/core/lib/common';
 import { WindowService } from '@theia/core/lib/browser/window/window-service';
 import { ArduinoPreferences } from '../arduino-preferences';
+import { SurveyNotificationService } from '../../common/protocol/survey-service';
 
 const SURVEY_MESSAGE = nls.localize(
   'arduino/survey/surveyMessage',
@@ -36,9 +37,15 @@ export class SurveyNotification implements FrontendApplicationContribution {
   @inject(ArduinoPreferences)
   private readonly arduinoPreferences: ArduinoPreferences;
 
+  @inject(SurveyNotificationService)
+  private readonly surveyNotificationService: SurveyNotificationService;
+
   onStart(): void {
     this.arduinoPreferences.ready.then(async () => {
-      if (this.arduinoPreferences.get('arduino.survey.notification')) {
+      if (
+        (await this.surveyNotificationService.isFirstInstance()) &&
+        this.arduinoPreferences.get('arduino.survey.notification')
+      ) {
         const surveyAnswered = await this.localStorageService.getData(
           this.surveyKey(surveyId)
         );

Diff for: arduino-ide-extension/src/common/protocol/survey-service.ts

@@ -0,0 +1,7 @@
+export const SurveyNotificationServicePath =
+  '/services/survey-notification-service';
+export const SurveyNotificationService = Symbol('SurveyNotificationService');
+
+export interface SurveyNotificationService {
+  isFirstInstance(): Promise<boolean>;
+}

Diff for: arduino-ide-extension/src/electron-main/arduino-electron-main-module.ts

@@ -21,6 +21,11 @@ import {
 import { IDEUpdaterImpl } from './ide-updater/ide-updater-impl';
 import { TheiaElectronWindow } from './theia/theia-electron-window';
 import { TheiaElectronWindow as DefaultTheiaElectronWindow } from '@theia/core/lib/electron-main/theia-electron-window';
+import { SurveyNotificationServiceImpl } from '../node/survey-service-impl';
+import {
+  SurveyNotificationService,
+  SurveyNotificationServicePath,
+} from '../common/protocol/survey-service';
 
 export default new ContainerModule((bind, unbind, isBound, rebind) => {
   bind(ElectronMainApplication).toSelf().inSingletonScope();
@@ -61,4 +66,21 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
 
   bind(TheiaElectronWindow).toSelf();
   rebind(DefaultTheiaElectronWindow).toService(TheiaElectronWindow);
+
+  // Survey notification bindings
+  bind(SurveyNotificationServiceImpl).toSelf().inSingletonScope();
+  bind(SurveyNotificationService).toService(SurveyNotificationServiceImpl);
+  bind(ElectronMainApplicationContribution).toService(
+    SurveyNotificationService
+  );
+  bind(ElectronConnectionHandler)
+    .toDynamicValue(
+      (context) =>
+        new JsonRpcConnectionHandler(SurveyNotificationServicePath, () =>
+          context.container.get<SurveyNotificationService>(
+            SurveyNotificationService
+          )
+        )
+    )
+    .inSingletonScope();
 });

Diff for: arduino-ide-extension/src/node/survey-service-impl.ts

@@ -0,0 +1,15 @@
+import { injectable } from '@theia/core/shared/inversify';
+import { SurveyNotificationService } from '../common/protocol/survey-service';
+
+@injectable()
+export class SurveyNotificationServiceImpl
+  implements SurveyNotificationService
+{
+  private isSurveyShown = false;
+  async isFirstInstance(): Promise<boolean> {
+    if (this.isSurveyShown) {
+      return false;
+    }
+    return (this.isSurveyShown = true);
+  }
+}