Skip to content

Commit 49971ad

Browse files
committed
Remove irrelevant trigger from "Compose full changelog" workflow
The "Compose full changelog" GitHub Actions workflow generates a changelog file from the release notes and uploads this to Arduino's server for display to the user by the IDE updater. Previously, this workflow could be triggered by either of two events: - Release creation - Release edit To reduce the possibility of endless recursion, GitHub Actions ignores events which are triggered using the auto-generated `GITHUB_TOKEN` access token. All release creations are done automatically by the "Arduino IDE" GitHub Actions workflow, which uses this token. For this reason, the release creation trigger will never be used. Since the behavior of the event being ignored by GitHub Actions under these conditions is not at all obvious, having the workflow configured for such an irrelevant trigger can cause confusion. The workflow will be triggered by the manual edit which is done on every release to format the raw release notes auto-generated from the commit history. So the fact that the release creation trigger doesn't work is not a problem.
1 parent e6b9d4e commit 49971ad

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Diff for: .github/workflows/compose-full-changelog.yaml

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ name: Compose full changelog
22

33
on:
44
release:
5-
types: [created, edited]
5+
types:
6+
- edited
67

78
env:
89
CHANGELOG_ARTIFACTS: changelog

0 commit comments

Comments
 (0)