update menu actions when autoScaleInterface changes

Author: Alberto Iannaccone

Diff for: arduino-ide-extension/src/browser/contributions/interface-scale.ts

@@ -44,6 +44,7 @@ export class InterfaceScale extends Contribution {
   override onStart(): MaybePromise<void> {
     const updateCurrent = (settings: Settings) => {
       this.currentSettings = settings;
+      this.updateFontScalingEnabled();
     };
     this.settingsService.onDidChange((settings) => updateCurrent(settings));
     this.settingsService.settings().then((settings) => updateCurrent(settings));
@@ -120,23 +121,14 @@ export class InterfaceScale extends Contribution {
     this.mainMenuManager.update();
   }
 
-  private updateFontSize(mode: 'increase' | 'decrease'): void {
-    if (this.currentSettings.autoScaleInterface) {
-      mode === 'increase'
-        ? (this.currentSettings.interfaceScale += InterfaceScale.ZoomLevel.STEP)
-        : (this.currentSettings.interfaceScale -=
-            InterfaceScale.ZoomLevel.STEP);
-    } else {
-      mode === 'increase'
-        ? (this.currentSettings.editorFontSize += InterfaceScale.FontSize.STEP)
-        : (this.currentSettings.editorFontSize -= InterfaceScale.FontSize.STEP);
-    }
-    let newFontScalingEnabled: InterfaceScale.FontScalingEnabled = {
+  private updateFontScalingEnabled(): void {
+    let fontScalingEnabled = {
       increase: true,
       decrease: true,
     };
+
     if (this.currentSettings.autoScaleInterface) {
-      newFontScalingEnabled = {
+      fontScalingEnabled = {
         increase:
           this.currentSettings.interfaceScale + InterfaceScale.ZoomLevel.STEP <=
           InterfaceScale.ZoomLevel.MAX,
@@ -145,7 +137,7 @@ export class InterfaceScale extends Contribution {
           InterfaceScale.ZoomLevel.MIN,
       };
     } else {
-      newFontScalingEnabled = {
+      fontScalingEnabled = {
         increase:
           this.currentSettings.editorFontSize + InterfaceScale.FontSize.STEP <=
           InterfaceScale.FontSize.MAX,
@@ -154,14 +146,29 @@ export class InterfaceScale extends Contribution {
           InterfaceScale.FontSize.MIN,
       };
     }
-    const isChanged = Object.keys(newFontScalingEnabled).some(
+
+    const isChanged = Object.keys(fontScalingEnabled).some(
       (key: keyof InterfaceScale.FontScalingEnabled) =>
-        newFontScalingEnabled[key] !== this.fontScalingEnabled[key]
+        fontScalingEnabled[key] !== this.fontScalingEnabled[key]
     );
     if (isChanged) {
-      this.fontScalingEnabled = newFontScalingEnabled;
+      this.fontScalingEnabled = fontScalingEnabled;
       this.registerMenus(this.menuRegistry);
     }
+  }
+
+  private updateFontSize(mode: 'increase' | 'decrease'): void {
+    if (this.currentSettings.autoScaleInterface) {
+      mode === 'increase'
+        ? (this.currentSettings.interfaceScale += InterfaceScale.ZoomLevel.STEP)
+        : (this.currentSettings.interfaceScale -=
+            InterfaceScale.ZoomLevel.STEP);
+    } else {
+      mode === 'increase'
+        ? (this.currentSettings.editorFontSize += InterfaceScale.FontSize.STEP)
+        : (this.currentSettings.editorFontSize -= InterfaceScale.FontSize.STEP);
+    }
+    this.updateFontScalingEnabled();
     this.updateSettingsDebounced();
   }