Do not start tasks to reset scroll in pref editor.

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

@@ -323,6 +323,10 @@ import { StatusBarImpl } from './theia/core/status-bar';
 import { StatusBarImpl as TheiaStatusBarImpl } from '@theia/core/lib/browser';
 import { EditorMenuContribution } from './theia/editor/editor-file';
 import { EditorMenuContribution as TheiaEditorMenuContribution } from '@theia/editor/lib/browser/editor-menu';
+import { PreferencesEditorWidget as TheiaPreferencesEditorWidget } from '@theia/preferences/lib/browser/views/preference-editor-widget';
+import { PreferencesEditorWidget } from './theia/preferences/preference-editor-widget';
+import { PreferencesWidget } from '@theia/preferences/lib/browser/views/preference-widget';
+import { createPreferencesWidgetContainer } from '@theia/preferences/lib/browser/views/preference-widget-bindings';
 
 const registerArduinoThemes = () => {
   const themes: MonacoThemeJson[] = [
@@ -845,6 +849,18 @@ export default new ContainerModule((bind, unbind, isBound, rebind) => {
   bind(DockPanelRenderer).toSelf();
   rebind(TheiaDockPanelRenderer).toService(DockPanelRenderer);
 
+  // Avoid running the "reset scroll" interval tasks until the preference editor opens.
+  rebind(PreferencesWidget)
+    .toDynamicValue(({ container }) => {
+      const child = createPreferencesWidgetContainer(container);
+      child.bind(PreferencesEditorWidget).toSelf().inSingletonScope();
+      child
+        .rebind(TheiaPreferencesEditorWidget)
+        .toService(PreferencesEditorWidget);
+      return child.get(PreferencesWidget);
+    })
+    .inSingletonScope();
+
   // Preferences
   bindArduinoPreferences(bind);
 

arduino-ide-extension/src/browser/theia/preferences/preference-editor-widget.ts

@@ -0,0 +1,19 @@
+import { injectable } from '@theia/core/shared/inversify';
+import { PreferencesEditorWidget as TheiaPreferencesEditorWidget } from '@theia/preferences/lib/browser/views/preference-editor-widget';
+
+@injectable()
+export class PreferencesEditorWidget extends TheiaPreferencesEditorWidget {
+  protected override resetScroll(
+    nodeIDToScrollTo?: string,
+    filterWasCleared = false
+  ): void {
+    if (this.scrollBar) {
+      // Absent on widget creation
+      this.doResetScroll(nodeIDToScrollTo, filterWasCleared);
+    } else {
+      // NOOP
+      // Unlike Theia, IDE2 does not start multiple tasks to check if the scrollbar is ready to reset it.
+      // If the "scroll reset" request arrived before the existence of the scrollbar, what to reset?
+    }
+  }
+}