Skip to content

Commit 286a687

Browse files
author
Alberto Iannaccone
committed
fix user fields UI
1 parent 6f782b5 commit 286a687

File tree

2 files changed

+37
-29
lines changed

2 files changed

+37
-29
lines changed

Diff for: arduino-ide-extension/src/browser/dialogs/user-fields/user-fields-component.tsx

+24-20
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export const UserFieldsComponent = ({
2626

2727
const updateUserField =
2828
(index: number) => (e: React.ChangeEvent<HTMLInputElement>) => {
29-
let newBoardUserFields = [...boardUserFields];
29+
const newBoardUserFields = [...boardUserFields];
3030
newBoardUserFields[index].value = e.target.value;
3131
setBoardUserFields(newBoardUserFields);
3232
};
@@ -48,26 +48,30 @@ export const UserFieldsComponent = ({
4848

4949
return (
5050
<div>
51-
{boardUserFields.map((field, index) => {
52-
return (
53-
<div className="dialogSection" key={index}>
54-
<div className="dialogRow">
55-
<label className="field-label">{field.label}</label>
56-
</div>
57-
<div className="dialogRow">
58-
<input
59-
type={field.secret ? 'password' : 'text'}
60-
value={field.value}
61-
className="theia-input"
62-
placeholder={'Enter ' + field.label}
63-
onChange={updateUserField(index)}
64-
/>
65-
</div>
66-
</div>
67-
);
68-
})}
51+
<div className="user-fields-container">
52+
<div className="user-fields-list">
53+
{boardUserFields.map((field, index) => {
54+
return (
55+
<div className="dialogSection" key={index}>
56+
<div className="dialogRow">
57+
<label className="field-label">{field.label}</label>
58+
</div>
59+
<div className="dialogRow">
60+
<input
61+
type={field.secret ? 'password' : 'text'}
62+
value={field.value}
63+
className="theia-input"
64+
placeholder={'Enter ' + field.label}
65+
onChange={updateUserField(index)}
66+
/>
67+
</div>
68+
</div>
69+
);
70+
})}
71+
</div>
72+
</div>
6973
<div className="dialogSection">
70-
<div className="dialogRow">
74+
<div className="dialogRow button-container">
7175
<button
7276
type="button"
7377
className="theia-button secondary install-cert-btn"
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
.user-fields-dialog-title {
2-
font-family: Open Sans;
3-
font-size: 16px;
4-
font-style: normal;
5-
font-weight: 700;
6-
line-height: 27px;
7-
letter-spacing: 0.01em;
8-
text-align: left;
1+
.user-fields-container {
2+
max-height: 332px;
3+
overflow: auto;
4+
padding: 2px;
5+
}
6+
7+
.user-fields-list {
8+
margin: 16px 0;
99
}
1010

1111
.user-fields-dialog-content {
1212
width: 408px;
13+
max-height: 491px;
1314
}
1415

1516
.user-fields-dialog-content .field-label {
1617
color: #2c353a;
17-
font-family: Open Sans;
1818
font-size: 14px;
1919
font-style: normal;
2020
font-weight: 400;
@@ -26,3 +26,7 @@
2626
.user-fields-dialog-content .theia-input {
2727
flex-grow: 1;
2828
}
29+
30+
.user-fields-dialog-content .button-container {
31+
justify-content: flex-end;
32+
}

0 commit comments

Comments
 (0)