fix: restore #1445

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/node/config-service-impl.ts

@@ -143,7 +143,19 @@ export class ConfigServiceImpl
     try {
       const cliConfig = await this.loadCliConfig();
       this.cliConfig = cliConfig;
-      const config = await this.mapCliConfigToAppConfig(this.cliConfig);
+      const [config] = await Promise.all([
+        this.mapCliConfigToAppConfig(this.cliConfig),
+        this.ensureUserDirExists(this.cliConfig).catch((reason) => {
+          if (reason instanceof Error) {
+            this.logger.warn(
+              `Could not ensure user directory existence: ${this.cliConfig?.directories.user}`,
+              reason
+            );
+          }
+          // NOOP. Try to create the folder if missing but swallow any errors.
+          // The validation will take care of the missing location handling.
+        }),
+      ]);
       this._configState.config = config;
       await this.validateCliConfig(this.cliConfig);
       delete this._configState.messages;
@@ -249,7 +261,6 @@ export class ConfigServiceImpl
   private async checkAccessible({
     directories,
   }: DefaultCliConfig): Promise<string[]> {
-    // Both data and user folders must be read and writable
     const accessible = (folderPath: string) =>
       fs.access(folderPath, constants.R_OK | constants.W_OK);
     const toConfigErrors = (
@@ -268,14 +279,11 @@ export class ConfigServiceImpl
             ),
           ]
         : [];
-    const { user, data } = directories;
-    const [userAccessible, dataAccessible] = await Promise.allSettled([
-      accessible(user),
-      accessible(data),
-    ]);
-    return ([] as string[])
-      .concat(toConfigErrors('user', user, userAccessible))
-      .concat(toConfigErrors('data', data, dataAccessible));
+    const { user } = directories;
+    const [userAccessible] = await Promise.allSettled([accessible(user)]); // XXX: validate `directory.data` if required
+    return ([] as string[]).concat(
+      toConfigErrors('user', user, userAccessible)
+    );
   }
 
   private async updateDaemon(
@@ -335,6 +343,13 @@ export class ConfigServiceImpl
       grpc.credentials.createInsecure()
     ) as SettingsServiceClient;
   }
+
+  // #1445
+  private async ensureUserDirExists(
+    cliConfig: DefaultCliConfig
+  ): Promise<void> {
+    await fs.mkdir(cliConfig.directories.user, { recursive: true });
+  }
 }
 
 class InvalidConfigError extends Error {