clean-up code

Author: Alberto Iannaccone

Diff for: arduino-ide-extension/src/node/monitor-settings/monitor-settings-provider-impl.ts

@@ -13,6 +13,7 @@ import {
   longestPrefixMatch,
   reconcileSettings,
 } from './monitor-settings-utils';
+import { ILogger } from '@theia/core';
 
 const MONITOR_SETTINGS_FILE = 'pluggable-monitor-settings.json';
 
@@ -21,6 +22,9 @@ export class MonitorSettingsProviderImpl implements MonitorSettingsProvider {
   @inject(EnvVariablesServer)
   protected readonly envVariablesServer: EnvVariablesServer;
 
+  @inject(ILogger)
+  protected logger: ILogger;
+
   // deferred used to guarantee file operations are performed after the service is initialized
   protected ready = new Deferred<void>();
 
@@ -43,8 +47,6 @@ export class MonitorSettingsProviderImpl implements MonitorSettingsProvider {
     // read existing settings
     await this.readSettingsFromFS();
 
-    console.log(this.monitorSettings);
-
     // init is done, resolve the deferred and unblock any call that was waiting for it
     this.ready.resolve();
   }
@@ -105,7 +107,7 @@ export class MonitorSettingsProviderImpl implements MonitorSettingsProvider {
     try {
       this.monitorSettings = JSON.parse(rawJson);
     } catch (error) {
-      console.error(
+      this.logger.error(
         'Could not parse the pluggable monitor settings file. Using empty file.'
       );
       this.monitorSettings = {};

Diff for: arduino-ide-extension/src/test/node/monitor-settings-utils.test.ts

@@ -7,8 +7,6 @@ import { PluggableMonitorSettings } from '../../node/monitor-settings/monitor-se
 
 type DeepWriteable<T> = { -readonly [P in keyof T]: DeepWriteable<T[P]> };
 
-// use(require('chai-string'));
-
 describe('longestPrefixMatch', () => {
   const settings = {
     'arduino:avr:uno-port1-protocol1': {