Skip to content

Commit f3501ee

Browse files
committed
Move definition of package filename to dedicated step in release workflow
The package filename is referenced in multiple places in the release workflow. In order to avoid code duplication, it is defined once as an environment variable, then that variable referenced in each of the instances where the filename is needed. Previously, this was done by first defining and referencing a shell environment variable at the point of the first usage, then defining a workflow environment variable and referencing that in the second usage. The maintainability and readability of the workflow is improved by using a single workflow environment variable, defined in the step dedicated to defining such variables, then referencing it consistently in all usages.
1 parent bd6a19a commit f3501ee

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/release-go-crosscompile-task.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ jobs:
9797
run: |
9898
# See: https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable
9999
echo "BUILD_FOLDER=${{ env.PROJECT_NAME }}_osx_${{ matrix.build.folder-suffix }}" >> "$GITHUB_ENV"
100+
TAG="${GITHUB_REF/refs\/tags\//}"
101+
echo "PACKAGE_FILENAME=${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}" >> $GITHUB_ENV
100102
101103
- name: Checkout repository
102104
uses: actions/checkout@v4
@@ -171,12 +173,9 @@ jobs:
171173
# GitHub's upload/download-artifact actions don't preserve file permissions,
172174
# so we need to add execution permission back until the action is made to do this.
173175
chmod +x "${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"
174-
TAG="${GITHUB_REF/refs\/tags\//}"
175-
PACKAGE_FILENAME="${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}"
176-
tar -czvf "$PACKAGE_FILENAME" \
176+
tar -czvf "${{ env.PACKAGE_FILENAME }}" \
177177
-C "${{ env.BUILD_FOLDER }}/" "${{ env.PROJECT_NAME }}" \
178178
-C ../../ LICENSE.txt
179-
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
180179
181180
- name: Upload artifact
182181
uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)