Skip to content

Commit dfbcf15

Browse files
umbynosper1234
andauthored
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent 726eb85 commit dfbcf15

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

Diff for: cli/common/common.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func GetUploadToolDir(packageIndex *packageindex.Index, board *firmwareindex.Ind
8080
}
8181

8282
// FlashSketch is the business logic that handles the flashing procedure,
83-
// it returns using a buffer the out and the err of the programmer
83+
// it returns using a buffer the stdout and the stderr of the programmer
8484
func FlashSketch(board *firmwareindex.IndexBoard, sketch string, uploadToolDir *paths.Path, address string) (programmerOut, programmerErr *bytes.Buffer, err error) {
8585
bootloaderPort, err := GetNewAddress(board, address)
8686
if err != nil {

Diff for: docs/usage.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ connection:
5757
Firmware version installed: 1.4.8
5858
```
5959

60-
You can also use the `--format json` to parse the output with more ease.
60+
You can also use the `--format json` flag to parse the output with more ease.
6161

6262
### Certificates
6363

Diff for: flasher/flasher.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ type FlashResult struct {
8686
Version string `json:"version,omitempty"`
8787
}
8888

89-
// ExecOutput contais the stdout and stderr output, they are used to store the output of the flashing and upload
89+
// ExecOutput contains the stdout and stderr output, they are used to store the output of the flashing and upload
9090
type ExecOutput struct {
9191
Stdout string `json:"stdout"`
9292
Stderr string `json:"stderr"`

Diff for: indexes/firmwareindex/firmwareindex.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ type IndexFirmware struct {
6767
Module string `json:"module,required"`
6868
}
6969

70-
// IndexSketch represents the sketch used to upload the new firmware on a board.
70+
// IndexSketch represents a sketch used to manage firmware on a board.
7171
type IndexSketch struct {
7272
URL string `json:"url,required"`
7373
Checksum string `json:"checksum,required"`

0 commit comments

Comments
 (0)