Skip to content

Commit 7ae8e67

Browse files
committed
Fix ArduinoISP sketch for Uno WiFi Rev2
When using bitbanged SPI, which the sketch did when compiled for any architecture other than AVR, a SPISettings class was declared by the sketch. At the time the sketch was written, it was reasonable to expect this would not cause a name collision, since SPI.h is not `#include`d when doing bit banged SPI. However, since then a SPISettings class has been declared in ArduinoCore-API's HardwareSPI.h, causing the ArduinoISP sketch to not compile for any board whose core uses ArduinoCoreAPI (currently Arduino Mega AVR Boards, "Arduino nRF528x Boards (Mbed OS)", and "Arduino Mbed OS Boards (nRF52840 / STM32H747)"): ``` /github/workspace/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino:191:27: error: reference to 'SPISettings' is ambiguous void beginTransaction(SPISettings settings) { ^~~~~~~~~~~ /github/workspace/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino:167:7: note: candidates are: class SPISettings class SPISettings { ^~~~~~~~~~~ In file included from /github/home/.arduino15/packages/arduino/hardware/megaavr/1.8.6/cores/arduino/api/ArduinoAPI.h:31:0, from /github/home/.arduino15/packages/arduino/hardware/megaavr/1.8.6/cores/arduino/Arduino.h:23, from /github/workspace/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino:39: /github/home/.arduino15/packages/arduino/hardware/megaavr/1.8.6/cores/arduino/api/HardwareSPI.h:37:7: note: class arduino::SPISettings class SPISettings { ^~~~~~~~~~~ ``` Although it's easy enough to fix the name collision, it seemed a better idea to simply use hardware SPI when compiling for the megaAVR architecture. --- After this change, I was able to use the Uno WiFi Rev2 as an "Arduino as ISP" programmer with "Burn Bootloader" and "Upload Using Programmer". It is necessary to use the **Tools > Programmer > Arduino as ISP (ATmega32U4)** programmer selection. --- Unfortunately, I found that, although the sketch now compiles for that board, I still can't use the Nano Every as an "Arduino as ISP" programmer. It is able to read the chip signature and read and write fuses, but there are `avrdude: stk500_recv(): programmer is not responding` errors while writing the program to flash. I found that the same issue occurs if I use the Nano Every and Nano 33 BLE with the bit banged SPI code (after fixing the name collision), while the Uno WiFi Rev2 works fine with the bit banged SPI.
1 parent 6336b9c commit 7ae8e67

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@
5454

5555

5656
// Select hardware or software SPI, depending on SPI clock.
57-
// Currently only for AVR, for other architectures (Due, Zero,...), hardware SPI
57+
// Currently only for AVR and megaAVR, for other architectures (Due, Zero,...), hardware SPI
5858
// is probably too fast anyway.
5959

60-
#if defined(ARDUINO_ARCH_AVR)
60+
#if defined(ARDUINO_ARCH_AVR) | defined(ARDUINO_ARCH_MEGAAVR)
6161

6262
#if SPI_CLOCK > (F_CPU / 128)
6363
#define USE_HARDWARE_SPI

0 commit comments

Comments
 (0)