replace library used to interact with tray bar #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
umbynos
force-pushed
the
umbynos/fyne_io
branch
2 times, most recently
from
2bbe8af to
8326af1
Compare
ubidefeo
approved these changes
Nov 30, 2022
umbynos
force-pushed
the
umbynos/fyne_io
branch
6 times, most recently
from
bda25fa to
64d02da
Compare
|
Apparently it's suggested to use CGO, even if on linux it works just fine fyne-io/systray@d16a617 |
|
The only downside of this PR is this https://github.com/fyne-io/systray#linuxbsd On my linux 18.04 the icon is not showing: But on newer machines should be working fine: @per1234 what do you think about this? |
umbynos
force-pushed
the
umbynos/fyne_io
branch
from
64d02da to
46c9e93
Compare
…on systems without a tray bar with this error: ``` systray error: failed to register our icon with the notifier watcher (maybe no tray is running?): The name org.kde.StatusNotifierWatcher was not provided by any .service files ```
there are no more dependencies required we can do this fyne-io/systray#24 (comment)
umbynos
force-pushed
the
umbynos/fyne_io
branch
from
46c9e93 to
88dbd62
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 20.93% 20.93%
=======================================
Files 43 43
Lines 3153 3162 +9
=======================================
+ Hits 660 662 +2
- Misses 2397 2404 +7
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmaglie
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
library change + infra enhancements
We currently use systray to interact with tray bar. On linux this requires libappindicator3 to work (v1.1.0). This library is old and deprecated. See debian release notes:
The new library is libayatana-appindicator which is supported by systray starting from version 1.2.0. But there seems to be problems with that version of the lib. See getlantern/systray#191 (comment). Using the fork https://github.com/fyne-io/systray seems to be a better alternative for various reasons:
go buildsystray error: failed to register our icon with the notifier watcher (maybe no tray is running?): The name org.kde.StatusNotifierWatcher was not provided by any .service files. So we do not need thearduino_create_agent-cliversion anymore.vs
no