Skip to content

[EDITOR-621] add port to serial output #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2021
Merged

[EDITOR-621] add port to serial output #616

merged 3 commits into from
Feb 11, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Feb 9, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

Currently we only get a serial object formatted like this {"D":"output text here\r\n"}

  • What is the new behavior?

The output now includes the port generating the output:

{
    "P": "dev/ttyACM0",
    "D":"output text here\r\n"
}
  • Does this PR introduce a breaking change?

Probably not

  • Other information:

@umbynos umbynos self-assigned this Feb 9, 2021
@umbynos
Copy link
Contributor Author

umbynos commented Feb 9, 2021 •
edited
Loading

@smellai please test binaries here

@umbynos umbynos added the type: enhancement Proposed improvement label Feb 9, 2021
@umbynos umbynos requested a review from smellai February 9, 2021 16:48
@umbynos umbynos merged commit b3860b0 into devel Feb 11, 2021
@umbynos umbynos deleted the umbynos/serial_port branch February 11, 2021 14:55
umbynos added a commit that referenced this pull request Feb 11, 2021
@umbynos
[EDITOR-621] add port to serial output (#616)
8d3a8cb 
* add port to serial output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smellai smellai smellai approved these changes

Assignees

@umbynos umbynos

Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbynos @smellai