Fix temp binary not starting correclty #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the binary ends with -temp gets restarted all over
umbynos
commented
Jan 5, 2021
Comment on lines
-140
to
+142
| Systray.Restart() | ||
| Systray.Update(newPath) |
There was a problem hiding this comment.
Restart() does not pass the path of the binary to start
Update() sets this path and then calls Restart()
umbynos
force-pushed
the
umbynos/fix_restart_bug
branch
from
2386dae to
cbd9df5
Compare
zmoog
reviewed
Jan 5, 2021
| panic(err) | ||
| } | ||
|
|
||
| Systray.Restart() | ||
| Systray.Update(newPath) |
zmoog
reviewed
Jan 5, 2021
Comment on lines
-35
to
+36
| fmt.Printf("Error getting exe path using osext lib. err: %v\n", err) | ||
| log.Printf("Error getting exe path using osext lib. err: %v\n", err) |
umbynos
added a commit
that referenced
this pull request
Jan 12, 2021
* fix strange temp binary file behavior: if the binary ends with -temp gets restarted all over * add some useful logs * Systray.Start() was called even if the program have to restart * added useful prints * replace fmt with a proper logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
bug fix
Fixes a regression introduced in #551 (https://github.com/arduino/arduino-create-agent/pull/551/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R139)
When the binary file ending with
-tempis manually started it does not start the correct bin file but it keeps starting itself.Fixed. Now when the temp binary is started it correctly copy itself to the full binary (binary file not ending with
-temp) and starts itno