Skip to content

Refactor systray #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Refactor systray #544

merged 2 commits into from
Apr 1, 2020

Conversation

matteosuppo
Copy link
Contributor

In order to chase a bug which caused the windows version to fail
to restart under some circumstances, I encapsulated the code
regarding the trayicon in a package.

The new version should be easier to mantain

Signed-off-by: Matteo Suppo [email protected]

In order to chase a bug which caused the windows version to fail
to restart under some circumstances, I encapsulated the code
regarding the trayicon in a package.

The new version should be easier to mantain

Signed-off-by: Matteo Suppo <[email protected]>
@matteosuppo matteosuppo requested a review from rsora March 31, 2020 14:15
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the systray_fake comment, It was not so easy to understand that we have it to allow an additional compile mode that produces a cli version of the agent
👍

@matteosuppo matteosuppo merged commit f973044 into devel Apr 1, 2020
@matteosuppo matteosuppo deleted the refactor_systray branch April 1, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants