From 5b34d40cfc4382c2eb602d6ec93d304ebf33c362 Mon Sep 17 00:00:00 2001
From: Matteo Suppo <matteo.suppo@gmail.com>
Date: Mon, 30 Mar 2020 15:52:49 +0200
Subject: [PATCH] Create manifest for windows and add instructions

---
 .gitignore   |  3 ++-
 README.md    | 30 ++++++++++++++++++++++++++++++
 manifest.xml | 15 +++++++++++++++
 3 files changed, 47 insertions(+), 1 deletion(-)
 create mode 100644 manifest.xml

diff --git a/.gitignore b/.gitignore
index 10cf9cf91..692d029fe 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,7 +1,8 @@
 
 bufferflow_tinyg_old.md
 
-arduino-create-agent
+arduino-create-agent*
+rsrc.syso
 
 snapshot/*
 public/
diff --git a/README.md b/README.md
index 849de638a..c7ac2fc82 100644
--- a/README.md
+++ b/README.md
@@ -414,6 +414,36 @@ Other prerequisites are:
 * libappindicator (Linux only on Ubuntu `sudo apt-get install libappindicator1 libappindicator3-0.1-cil libappindicator3-0.1-cil-dev libappindicator3-1 libappindicator3-dev libgtk-3-0 libgtk-3-dev`)
 * [go-selfupdate] (https://github.com/sanbornm/go-selfupdate) if you want to test automatic updates
 
+### Windows
+Since we are using the https://github.com/lxn/walk library, we need to ship a manifest.xml file, otherwise the error would be:
+
+```
+panic: Unable to create main window: TTM_ADDTOOL failed
+```
+
+To do it make sure to install the required tool:
+
+```
+$ go get github.com/akavel/rsrc
+```
+
+and build it with
+
+```
+$ rsrc -arch=386 -manifest=manifest.xml
+$ go build
+```
+
+Keep in mind that the presence of rsrc.syso file will break other builds, for example
+
+```
+$ GOOS=linux go build
+# github.com/arduino/arduino-create-agent
+/usr/lib/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
+/usr/sbin/ld: i386 architecture of input file `/tmp/go-link-084341451/000000.o' is incompatible with i386:x86-64 output
+collect2: error: ld returned 1 exit status
+```
+
 ## Submitting an issue
 
 Please attach the output of the commands running at the debug console if useful.
diff --git a/manifest.xml b/manifest.xml
new file mode 100644
index 000000000..18843e033
--- /dev/null
+++ b/manifest.xml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
+    <assemblyIdentity version="1.0.0.0" processorArchitecture="*" name="Arduino Create Agent" type="win32"/>
+    <dependency>
+        <dependentAssembly>
+            <assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0.0" processorArchitecture="*" publicKeyToken="6595b64144ccf1df" language="*"/>
+        </dependentAssembly>
+    </dependency>
+    <application xmlns="urn:schemas-microsoft-com:asm.v3">
+        <windowsSettings>
+            <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2, PerMonitor</dpiAwareness>
+            <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">True</dpiAware>
+        </windowsSettings>
+    </application>
+</assembly>
\ No newline at end of file