From dc97c077ad2732201360677dc59717f1d4d0f968 Mon Sep 17 00:00:00 2001 From: Murilo Polese <murilopolese@gmail.com> Date: Fri, 7 Dec 2018 15:05:39 +0000 Subject: [PATCH 1/3] Update build docs --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 264cd22dc..9d957c6f6 100644 --- a/README.md +++ b/README.md @@ -380,7 +380,7 @@ The results of the upload will be delivered via websocket with messages that loo ## Development -Please remember that for compile the project, you need go version <= 1.8.7 (more recent versions are not supported for compile) +Please remember that for compile the project, you need go version >= 1.10.x (older versions are not supported for compile) To clone the repository, run the following command: ``` @@ -398,7 +398,7 @@ go build This will create the `arduino-create-agent` binary. Other prerequisites are: -* libappindicator (Linux only on Ubuntu `sudo apt-get install libappindicator1`) +* libappindicator (Linux only on Ubuntu `sudo apt-get install libappindicator1 libappindicator3-0.1-cil libappindicator3-0.1-cil-dev libappindicator3-1 libappindicator3-dev libgtk-3-0 libgtk-3-dev`) * [go-selfupdate] (https://github.com/sanbornm/go-selfupdate) if you want to test automatic updates ## Submitting an issue From da67d01ba425a5208425fa50f8298ff67a115a8b Mon Sep 17 00:00:00 2001 From: Matteo Suppo <matteo.suppo@gmail.com> Date: Mon, 4 Mar 2019 12:37:17 +0100 Subject: [PATCH 2/3] Return info about the system --- info.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/info.go b/info.go index ad694fc47..c597c29d7 100644 --- a/info.go +++ b/info.go @@ -1,6 +1,7 @@ package main import ( + "runtime" "strings" "github.com/gin-gonic/gin" @@ -20,6 +21,7 @@ func infoHandler(c *gin.Context) { "wss": "wss://localhost" + portSSL, "origins": origins, "update_url": updateUrl, + "os": runtime.GOOS + ":" + runtime.GOARCH, }) } From bcce62872075bfb209ce175a891cabda7f83714b Mon Sep 17 00:00:00 2001 From: Roberto Sora <r.sora@arduino.cc> Date: Mon, 4 Mar 2019 17:45:03 +0100 Subject: [PATCH 3/3] sanitize paths when replacing {runtime.platform.path} --- upload/upload.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upload/upload.go b/upload/upload.go index 765ce1b2b..cecf2c449 100644 --- a/upload/upload.go +++ b/upload/upload.go @@ -55,7 +55,7 @@ func PartiallyResolve(board, file, platformPath, commandline string, extra Extra commandline = strings.Replace(commandline, "{build.path}", filepath.ToSlash(filepath.Dir(file)), -1) commandline = strings.Replace(commandline, "{build.project_name}", strings.TrimSuffix(filepath.Base(file), filepath.Ext(filepath.Base(file))), -1) commandline = strings.Replace(commandline, "{network.password}", extra.Auth.Password, -1) - commandline = strings.Replace(commandline, "{runtime.platform.path}", platformPath, -1) + commandline = strings.Replace(commandline, "{runtime.platform.path}", filepath.ToSlash(platformPath), -1) if extra.Verbose == true { commandline = strings.Replace(commandline, "{upload.verbose}", extra.ParamsVerbose, -1)