Skip to content

Commit f31e985

Browse files
committed
Revert "let gon generate the dmg installer and upload it"
Gon is able to produce a working dmg, but there is not a link to application and a background img, for that we need `create-dmg` This reverts commit 7bb8b91.
1 parent e7c1b1d commit f31e985

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

.github/workflows/release.yml

+3-8
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,6 @@ jobs:
288288
deep = true
289289
}
290290
291-
# generate a Disk Image
292-
dmg {
293-
output_path = "ArduinoCreateAgent_${{ matrix.arch }}_notarized.dmg"
294-
volume_name = "ArduinoCreateAgent"
295-
}
296291
# Ask Gon for zip output to force notarization process to take place.
297292
# The CI will upload the zip output
298293
zip {
@@ -322,11 +317,11 @@ jobs:
322317
aws s3 cp darwin-${{ matrix.arch }}-bundle.json s3://${{ secrets.DOWNLOADS_BUCKET }}${{ env.TARGET }}
323318
if: ${{ needs.build.outputs.prerelease != 'true' }}
324319

325-
- name: Upload artifacts
320+
- name: Upload artifact
326321
uses: actions/upload-artifact@v3
327322
with:
328-
name: ArduinoCreateAgent_${{ matrix.arch }}_notarized
329-
path: ArduinoCreateAgent_${{ matrix.arch }}_notarized.dmg
323+
name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized
324+
path: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
330325
if-no-files-found: error
331326

332327
# This job is responsible for generating the installers (using installbuilder)

0 commit comments

Comments
 (0)