Skip to content

Commit e4f4c0d

Browse files
committed
the _cli binary is no more required since it correctly starts even on systems without a tray bar with this error:
``` systray error: failed to register our icon with the notifier watcher (maybe no tray is running?): The name org.kde.StatusNotifierWatcher was not provided by any .service files ``` TODO test this on multiple OS/platform
1 parent 2fac85e commit e4f4c0d

File tree

4 files changed

+2
-25
lines changed

4 files changed

+2
-25
lines changed

.github/workflows/publish-go-tester-task.yml

-5
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,6 @@ jobs:
103103
run: task go:build
104104
if: runner.os == 'Linux'
105105

106-
# build the agent without GUI support (no tray icon)
107-
- name: Build the Agent-cli
108-
run: task go:build-cli
109-
if: runner.os == 'Linux'
110-
111106
# the manifest is required by windows GUI apps, otherwise the binary will crash with: "Unable to create main window: TTM_ADDTOOL failed" (for reference https://github.com/lxn/walk/issues/28)
112107
# rsrc will produce a *.syso file that should get automatically recognized by go build command and linked into an executable.
113108
- name: Download tool to embed manifest in win binary

.github/workflows/release.yml

-9
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,6 @@ jobs:
8484
run: task go:build
8585
if: matrix.os == 'ubuntu-18.04'
8686

87-
# build the agent without GUI support (no tray icon)
88-
- name: Build the Agent-cli
89-
run: task go:build-cli
90-
if: matrix.os == 'ubuntu-18.04'
91-
9287
# the manifest is required by windows GUI apps, otherwise the binary will crash with: "Unable to create main window: TTM_ADDTOOL failed" (for reference https://github.com/lxn/walk/issues/28)
9388
# rsrc will produce a *.syso file that should get automatically recognized by go build command and linked into an executable.
9489
- name: Download tool to embed manifest in win binary
@@ -275,10 +270,6 @@ jobs:
275270
- name: Rename executable to Arduino_Create_Agent
276271
run: mv -v ${{ matrix.executable-path }}arduino-create-agent${{ matrix.extension }} ${{ matrix.executable-path }}Arduino_Create_Agent${{ matrix.extension }}
277272

278-
- name: Rename executable to Arduino_Create_Agent_cli
279-
run: mv -v ${{ matrix.executable-path }}arduino-create-agent_cli${{ matrix.extension }} ${{ matrix.executable-path }}Arduino_Create_Agent_cli${{ matrix.extension }}
280-
if: matrix.os == 'ubuntu-18.04'
281-
282273
- name: get year
283274
run: echo "YEAR=$(date "+%Y")" >> $GITHUB_ENV
284275
if: matrix.os == 'macos-11'

.github/workflows/test-go-integration-task.yml

-9
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,5 @@ jobs:
9393
repo-token: ${{ secrets.GITHUB_TOKEN }}
9494
version: 3.x
9595

96-
# build the agent without GUI support (no tray icon) for integration testing
97-
- name: Build the Agent-cli
98-
run: task go:build-cli
99-
if: matrix.operating-system != 'windows-latest'
100-
101-
- name: Build the Agent-cli for win
102-
run: task go:build-win-cli
103-
if: matrix.operating-system == 'windows-latest'
104-
10596
- name: Run integration tests
10697
run: task go:test-integration

tests/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
@pytest.fixture(scope="function")
2828
def agent(pytestconfig):
2929

30-
agent_cli = str(Path(pytestconfig.rootdir) / "arduino-create-agent_cli")
30+
agent = str(Path(pytestconfig.rootdir) / "arduino-create-agent")
3131
env = {
3232
# "ARDUINO_DATA_DIR": data_dir,
3333
# "ARDUINO_DOWNLOADS_DIR": downloads_dir,
@@ -39,7 +39,7 @@ def agent(pytestconfig):
3939

4040
cd_command = "cd"
4141
with run_context.prefix(f'{cd_command} ..'):
42-
runner.run(agent_cli, echo=True, hide=True, warn=True, env=env, asynchronous=True)
42+
runner.run(agent, echo=True, hide=True, warn=True, env=env, asynchronous=True)
4343

4444
# we give some time to the agent to start and listen to
4545
# incoming requests

0 commit comments

Comments
 (0)