use embed and template

Author: umbynos

config/ArduinoCreateAgent.plist

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+	<dict>
+		<key>KeepAlive</key>
+		<false/>
+		<key>Label</key>
+		<string>ArduinoCreateAgent</string>
+		<key>Program</key>
+		<string>{{.Program}}</string>
+		<key>RunAtLoad</key>
+		<{{.RunAtLoad}}/>
+		<key>AbandonProcessGroup</key>
+		<true/>
+	</dict>
+</plist>

config/autostart.go

@@ -15,14 +15,20 @@
 package config
 
 import (
+	// we need this for the ArduinoCreateAgent.plist in this package
+	_ "embed"
 	"fmt"
 	"os"
 	"os/exec"
+	"text/template"
 
 	"github.com/arduino/go-paths-helper"
 	log "github.com/sirupsen/logrus"
 )
 
+//go:embed ArduinoCreateAgent.plist
+var launchdAgentDefinition []byte
+
 // getLaunchdAgentPath will return the path of the launchd agent default path
 func getLaunchdAgentPath() *paths.Path {
 	return GetDefaultHomeDir().Join("Library", "LaunchAgents", "ArduinoCreateAgent.plist")
@@ -32,52 +38,43 @@ func getLaunchdAgentPath() *paths.Path {
 // it will return nil in case of success,
 // it will error if the file is already there or in any other case
 func WritePlistFile() error {
-	src, err := os.Executable()
-	if err != nil {
-		return err
-	}
 
 	launchdAgentPath := getLaunchdAgentPath()
-
-	// For now this file comes from the installbuilder autogenerated one
-	launchdAgentDefinition := `<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-	<dict>
-		<key>KeepAlive</key>
-		<false/>
-		<key>Label</key>
-		<string>ArduinoCreateAgent</string>
-		<key>ProgramArguments</key>
-		<array>
-			<string>` + src + `</string>
-		</array>
-		<key>RunAtLoad</key>
-		<true/>
-
-		<key>AbandonProcessGroup</key>
-		<true/>
-	</dict>
-</plist>
-`
 	if launchdAgentPath.Exist() {
-		// TODO check for differences in files(?)
 		// we already have an existing launchd plist file, so we don't have to do anything
 		return fmt.Errorf("the autostart file %s already exists", launchdAgentPath)
 	}
-	// we need to create a new one
-	return launchdAgentPath.WriteFile([]byte(launchdAgentDefinition))
+
+	src, err := os.Executable()
+	if err != nil {
+		return err
+	}
+	data := struct {
+		Program   string
+		RunAtLoad bool
+	}{
+		Program:   src,
+		RunAtLoad: false,
+	}
+
+	t := template.Must(template.New("launchdConfig").Parse(string(launchdAgentDefinition)))
+
+	// we need to create a new launchd plist file
+	plistFile, _ := launchdAgentPath.Create()
+	return t.Execute(plistFile, data)
 }
 
 // LoadLaunchdAgent will use launchctl to load the agent, will return an error if something goes wrong
 func LoadLaunchdAgent() error {
+	// https://www.launchd.info/
 	oscmd := exec.Command("launchctl", "load", getLaunchdAgentPath().String())
 	err := oscmd.Run()
 	return err
 }
 
 // UnloadLaunchdAgent will use launchctl to load the agent, will return an error if something goes wrong
 func UnloadLaunchdAgent() error {
+	// https://www.launchd.info/
 	oscmd := exec.Command("launchctl", "unload", getLaunchdAgentPath().String())
 	err := oscmd.Run()
 	return err
@@ -93,6 +90,3 @@ func RemovePlistFile() error {
 	}
 	return nil
 }
-
-// TODO win/linux ?
-// TODO read the doc about launchd https://www.launchd.info/