fix task go:lint

Author: umbynos

Taskfile.yml

@@ -30,7 +30,7 @@ tasks:
     desc: Build the project, to use a specific version use `task build TAG_VERSION=x.x.x`
     dir: "{{.DEFAULT_GO_MODULE_PATH}}"
     cmds:
-      - go build -v -i {{default "" .ADDITIONAL_FLAGS}} -o {{default "arduino-create-agent" .APP_NAME}} -ldflags '-X main.version={{default .TAG_TEST .TAG_VERSION}} -X main.git_revision={{.COMMIT}} {{default "" .WIN_FLAGS}}'
+      - go build -v -i {{default "" .ADDITIONAL_FLAGS}} -o {{default "arduino-create-agent" .APP_NAME}} -ldflags '-X main.version={{default .TAG_TEST .TAG_VERSION}} -X main.commit={{.COMMIT}} {{default "" .WIN_FLAGS}}'
     vars:
       COMMIT:
         sh: git log -n 1 --format=%h

bufferflow.go

@@ -15,6 +15,7 @@
 
 package main
 
+// Bufferflow interface
 type Bufferflow interface {
 	Init()
 	OnIncomingData(data string) // implement this method

bufferflow_default.go

@@ -21,13 +21,15 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
+// BufferflowDefault is the default bufferflow, whick means no buffering
 type BufferflowDefault struct {
 	port   string
 	output chan<- []byte
 	input  chan string
 	done   chan bool
 }
 
+// NewBufferflowDefault create a new default bufferflow
 func NewBufferflowDefault(port string, output chan<- []byte) *BufferflowDefault {
 	return &BufferflowDefault{
 		port:   port,
@@ -37,6 +39,7 @@ func NewBufferflowDefault(port string, output chan<- []byte) *BufferflowDefault
 	}
 }
 
+// Init will initialize the bufferflow
 func (b *BufferflowDefault) Init() {
 	log.Println("Initting default buffer flow (which means no buffering)")
 	go b.consumeInput()
@@ -57,10 +60,12 @@ Loop:
 	close(b.input) // close the input channel at the end of the computation
 }
 
+// OnIncomingData will forward the data
 func (b *BufferflowDefault) OnIncomingData(data string) {
 	b.input <- data
 }
 
+// Close will close the bufferflow
 func (b *BufferflowDefault) Close() {
 	b.done <- true
 	close(b.done)

bufferflow_timed.go

@@ -22,6 +22,7 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
+// BufferflowTimed sends data once every 16ms
 type BufferflowTimed struct {
 	port           string
 	output         chan<- []byte
@@ -32,6 +33,7 @@ type BufferflowTimed struct {
 	bufferedOutput string
 }
 
+// NewBufferflowTimed will create a new timed bufferflow
 func NewBufferflowTimed(port string, output chan<- []byte) *BufferflowTimed {
 	return &BufferflowTimed{
 		port:           port,
@@ -44,6 +46,7 @@ func NewBufferflowTimed(port string, output chan<- []byte) *BufferflowTimed {
 	}
 }
 
+// Init will initialize the bufferflow
 func (b *BufferflowTimed) Init() {
 	log.Println("Initting timed buffer flow (output once every 16ms)")
 	go b.consumeInput()
@@ -72,10 +75,12 @@ Loop:
 	close(b.input)
 }
 
+// OnIncomingData will forward the data
 func (b *BufferflowTimed) OnIncomingData(data string) {
 	b.input <- data
 }
 
+// Close will close the bufferflow
 func (b *BufferflowTimed) Close() {
 	b.ticker.Stop()
 	b.done <- true

bufferflow_timedraw.go

@@ -22,6 +22,7 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
+// BufferflowTimedRaw sends raw data once every 16ms
 type BufferflowTimedRaw struct {
 	port              string
 	output            chan<- []byte
@@ -32,6 +33,7 @@ type BufferflowTimedRaw struct {
 	sPortRaw          string
 }
 
+// NewBufferflowTimedRaw will create a new raw bufferflow
 func NewBufferflowTimedRaw(port string, output chan<- []byte) *BufferflowTimedRaw {
 	return &BufferflowTimedRaw{
 		port:              port,
@@ -44,6 +46,7 @@ func NewBufferflowTimedRaw(port string, output chan<- []byte) *BufferflowTimedRa
 	}
 }
 
+// Init will initialize the bufferflow
 func (b *BufferflowTimedRaw) Init() {
 	log.Println("Initting timed buffer raw flow (output once every 16ms)")
 	go b.consumeInput()
@@ -73,10 +76,12 @@ Loop:
 	close(b.input)
 }
 
+// OnIncomingData will forward the data
 func (b *BufferflowTimedRaw) OnIncomingData(data string) {
 	b.input <- data
 }
 
+// Close will close the bufferflow
 func (b *BufferflowTimedRaw) Close() {
 	b.ticker.Stop()
 	b.done <- true

certificates.go

@@ -75,7 +75,7 @@ func generateKey(ecdsaCurve string) (interface{}, error) {
 	case "P521":
 		return ecdsa.GenerateKey(elliptic.P521(), rand.Reader)
 	default:
-		return nil, fmt.Errorf("Unrecognized elliptic curve: %q", ecdsaCurve)
+		return nil, fmt.Errorf("unrecognized elliptic curve: %q", ecdsaCurve)
 	}
 }
 
@@ -87,7 +87,7 @@ func generateSingleCertificate(isCa bool) (*x509.Certificate, error) {
 	} else {
 		notBefore, err = time.Parse("Jan 2 15:04:05 2006", validFrom)
 		if err != nil {
-			return nil, fmt.Errorf("Failed to parse creation date: %s\n", err.Error())
+			return nil, fmt.Errorf("failed to parse creation date: %s", err.Error())
 		}
 	}
 
@@ -96,7 +96,7 @@ func generateSingleCertificate(isCa bool) (*x509.Certificate, error) {
 	serialNumberLimit := new(big.Int).Lsh(big.NewInt(1), 128)
 	serialNumber, err := rand.Int(rand.Reader, serialNumberLimit)
 	if err != nil {
-		return nil, fmt.Errorf("failed to generate serial number: %s\n", err.Error())
+		return nil, fmt.Errorf("failed to generate serial number: %s", err.Error())
 	}
 
 	template := x509.Certificate{
@@ -164,7 +164,7 @@ func generateCertificates() {
 		os.Exit(1)
 	}
 
-	derBytes, err := x509.CreateCertificate(rand.Reader, caTemplate, caTemplate, publicKey(caKey), caKey)
+	derBytes, _ := x509.CreateCertificate(rand.Reader, caTemplate, caTemplate, publicKey(caKey), caKey)
 
 	certOut, err := os.Create("ca.cert.pem")
 	if err != nil {
@@ -202,7 +202,7 @@ func generateCertificates() {
 		os.Exit(1)
 	}
 
-	derBytes, err = x509.CreateCertificate(rand.Reader, template, caTemplate, publicKey(key), caKey)
+	derBytes, _ = x509.CreateCertificate(rand.Reader, template, caTemplate, publicKey(key), caKey)
 
 	certOut, err = os.Create("cert.pem")
 	if err != nil {
@@ -233,6 +233,7 @@ func deleteCertHandler(c *gin.Context) {
 	DeleteCertificates()
 }
 
+// DeleteCertificates will delete the certificates
 func DeleteCertificates() {
 	os.Remove("ca.cert.pem")
 	os.Remove("ca.cert.cer")

conn.go

@@ -45,8 +45,7 @@ type connection struct {
 	ws socketio.Socket
 
 	// Buffered channel of outbound messages.
-	send     chan []byte
-	incoming chan []byte
+	send chan []byte
 }
 
 func (c *connection) writer() {
@@ -67,7 +66,7 @@ func (s *WsServer) ServeHTTP(c *gin.Context) {
 	s.Server.ServeHTTP(c.Writer, c.Request)
 }
 
-type AdditionalFile struct {
+type additionalFile struct {
 	Hex      []byte `json:"hex"`
 	Filename string `json:"filename"`
 }
@@ -82,7 +81,7 @@ type Upload struct {
 	Extra       upload.Extra     `json:"extra"`
 	Hex         []byte           `json:"hex"`
 	Filename    string           `json:"filename"`
-	ExtraFiles  []AdditionalFile `json:"extrafiles"`
+	ExtraFiles  []additionalFile `json:"extrafiles"`
 }
 
 var uploadStatusStr = "ProgrammerStatus"
@@ -105,7 +104,7 @@ func uploadHandler(c *gin.Context) {
 		return
 	}
 
-	if data.Extra.Network == false {
+	if !data.Extra.Network {
 		if data.Signature == "" {
 			c.String(http.StatusBadRequest, "signature is required")
 			return

discovery.go

@@ -128,7 +128,7 @@ func getPorts() ([]OsSerialPort, error) {
 		for e := range results {
 			log.Printf("%+v", e)
 			if e.AddrIPv4 != nil {
-				arrPorts = append(arrPorts, OsSerialPort{Name: e.AddrIPv4.String(), IdProduct: e.Instance, IdVendor: strings.Join(e.Text[:], " "), NetworkPort: true})
+				arrPorts = append(arrPorts, OsSerialPort{Name: e.AddrIPv4.String(), IDProduct: e.Instance, IDVendor: strings.Join(e.Text[:], " "), NetworkPort: true})
 			}
 		}
 		timeout <- true
@@ -140,10 +140,8 @@ func getPorts() ([]OsSerialPort, error) {
 		return nil, err
 	}
 	// wait for some kind of timeout and return arrPorts
-	select {
-	case <-timeout:
-		return arrPorts, nil
-	}
+	<-timeout
+	return arrPorts, nil
 }
 
 // Filter returns a new slice containing all OsSerialPort in the slice that satisfy the predicate f.

hub.go

@@ -123,7 +123,7 @@ func checkCmd(m []byte) {
 
 	sl := strings.ToLower(strings.Trim(s, "\n"))
 
-	if *hibernate == true {
+	if *hibernate {
 		//do nothing
 		return
 	}
@@ -246,12 +246,12 @@ func checkCmd(m []byte) {
 func logAction(sl string) {
 	if strings.HasPrefix(sl, "log on") {
 		*logDump = "on"
-		multi_writer := io.MultiWriter(&logger_ws, os.Stderr)
-		log.SetOutput(multi_writer)
+		multiWriter := io.MultiWriter(&loggerWs, os.Stderr)
+		log.SetOutput(multiWriter)
 	} else if strings.HasPrefix(sl, "log off") {
 		*logDump = "off"
 		log.SetOutput(os.Stderr)
-	} else if strings.HasPrefix(sl, "log show") {
+		// } else if strings.HasPrefix(sl, "log show") {
 		// TODO: send all the saved log to websocket
 		//h.broadcastSys <- []byte("{\"BufFlowDebug\" : \"" + *logDump + "\"}")
 	}