Skip to content

Commit 3ba51ce

Browse files
authored
Fix autoupdate bundle (#853)
* remove `--keepParent`, it's breaking the autoupdate bundle. This flag was introduced by mistake, inside gon only `-c -k` were used https://github.com/mitchellh/gon/blob/2d4f161ccecd1aae878f4416d5ccd622b1b01fdb/package/zip/zip.go#L59 * Revert "remove top level dir it's already there thanks to `ditto --keepParent" This reverts commit 134d250.
1 parent 35a05dc commit 3ba51ce

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/release.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ jobs:
295295
run: gon -log-level=debug -log-json "${{ env.GON_CONFIG_PATH }}"
296296

297297
- name: Zip output app bundle
298-
run: ditto -c -k --keepParent ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
298+
run: ditto -c -k ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
299299

300300
- name: Remove gon used for code signing
301301
run: |
@@ -455,10 +455,13 @@ jobs:
455455
uses: actions/download-artifact@v3
456456
with:
457457
name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized
458+
path: ArduinoCreateAgent.app
458459

459460
- name: unzip artifact
461+
working-directory: ArduinoCreateAgent.app
460462
run: |
461463
unzip ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
464+
rm ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
462465
463466
- name: Install create-dmg
464467
run: brew install create-dmg

0 commit comments

Comments
 (0)