Skip to content

Commit 39c26e2

Browse files
committed
fix wrongly set windows version variable
`task build-win TAG_VERSION=${GITHUB_REF##*/}` is not working on win
1 parent 61a0d5a commit 39c26e2

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

.github/workflows/release.yml

+9-5
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ jobs:
2121
runs-on: ${{ matrix.operating-system }}
2222

2323
steps:
24+
- name: Set version
25+
run: echo "TAG_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
26+
shell: bash
27+
2428
- name: Disable EOL conversions
2529
run: git config --global core.autocrlf false
2630

@@ -59,12 +63,12 @@ jobs:
5963
run: task test-unit
6064

6165
- name: Build the Agent for linux
62-
run: task build TAG_VERSION=${GITHUB_REF##*/}
66+
run: task build
6367
if: matrix.operating-system == 'ubuntu-18.04'
6468

6569
# build the agent without GUI support (no tray icon)
6670
- name: Build the Agent-cli
67-
run: task build-cli TAG_VERSION=${GITHUB_REF##*/}
71+
run: task build-cli
6872
if: matrix.operating-system == 'ubuntu-18.04'
6973

7074
# the manifest is required by windows GUI apps, otherwise the binary will crash with: "Unable to create main window: TTM_ADDTOOL failed" (for reference https://github.com/lxn/walk/issues/28)
@@ -78,19 +82,19 @@ jobs:
7882
env:
7983
GOARCH: 386 # 32bit architecture (for support)
8084
GO386: 387 # support old instruction sets without MMX (used in the Pentium 4) (will be deprecated in GO > 1.15 https://golang.org/doc/go1.15)
81-
run: task build-win TAG_VERSION=${GITHUB_REF##*/}
85+
run: task build-win
8286
if: matrix.operating-system == 'windows-2019' && matrix.arch == '-386'
8387

8488
- name: Build the Agent for win64
85-
run: task build-win TAG_VERSION=${GITHUB_REF##*/} # GOARCH=amd64 by default on the runners
89+
run: task build-win # GOARCH=amd64 by default on the runners
8690
if: matrix.operating-system == 'windows-2019' && matrix.arch == '-amd64'
8791

8892
- name: Build the Agent for macos
8993
env:
9094
MACOSX_DEPLOYMENT_TARGET: 10.11 # minimum supported version for mac
9195
CGO_CFLAGS: -mmacosx-version-min=10.11
9296
CGO_LDFLAGS: -mmacosx-version-min=10.11
93-
run: task build TAG_VERSION=${GITHUB_REF##*/}
97+
run: task build
9498
if: matrix.operating-system == 'macos-10.15'
9599

96100
# config.ini is required by the executable when it's run

0 commit comments

Comments
 (0)