apply suggestions from code review ✨

Author: umbynos

bufferflow.go

@@ -1,15 +1,5 @@
 package main
 
-// availableBufferAlgorithms = {"default", "timed", "timedraw", "timedbinary"}
-
-type BufferMsg struct {
-	Cmd                string
-	Port               string
-	TriggeringResponse string
-	//Desc string
-	//Desc string
-}
-
 type Bufferflow interface {
 	Init()
 	BlockUntilReady(cmd string, id string) (bool, bool) // implement this method

bufferflow_default.go

@@ -8,12 +8,12 @@ import (
 
 type BufferflowDefault struct {
 	port   string
-	output chan []byte
+	output chan<- []byte
 	input  chan string
 	done   chan bool
 }
 
-func NewBufferflowDefault(port string, output chan []byte) *BufferflowDefault {
+func NewBufferflowDefault(port string, output chan<- []byte) *BufferflowDefault {
 	return &BufferflowDefault{
 		port:   port,
 		output: output,

bufferflow_timed.go

@@ -9,15 +9,15 @@ import (
 
 type BufferflowTimed struct {
 	port           string
-	output         chan []byte
+	output         chan<- []byte
 	input          chan string
 	done           chan bool
 	ticker         *time.Ticker
 	sPort          string
 	bufferedOutput string
 }
 
-func NewBufferflowTimed(port string, output chan []byte) *BufferflowTimed {
+func NewBufferflowTimed(port string, output chan<- []byte) *BufferflowTimed {
 	return &BufferflowTimed{
 		port:           port,
 		output:         output,

bufferflow_timedbinary.go

@@ -9,15 +9,15 @@ import (
 
 type BufferflowTimedBinary struct {
 	port                 string
-	output               chan []byte
+	output               chan<- []byte
 	input                chan []byte
 	done                 chan bool
 	ticker               *time.Ticker
 	bufferedOutputBinary []byte
 	sPortBinary          string
 }
 
-func NewBufferflowTimedBinary(port string, output chan []byte) *BufferflowTimedBinary {
+func NewBufferflowTimedBinary(port string, output chan<- []byte) *BufferflowTimedBinary {
 	return &BufferflowTimedBinary{
 		port:                 port,
 		output:               output,
@@ -68,10 +68,6 @@ func (b *BufferflowTimedBinary) OnIncomingData(data string) {
 	b.input <- []byte(data)
 }
 
-func (b *BufferflowTimedBinary) IsBufferGloballySendingBackIncomingData() bool {
-	return true
-}
-
 func (b *BufferflowTimedBinary) Close() {
 	b.ticker.Stop()
 	b.done <- true

bufferflow_timedraw.go

@@ -9,15 +9,15 @@ import (
 
 type BufferflowTimedRaw struct {
 	port              string
-	output            chan []byte
+	output            chan<- []byte
 	input             chan string
 	done              chan bool
 	ticker            *time.Ticker
 	bufferedOutputRaw []byte
 	sPortRaw          string
 }
 
-func NewBufferflowTimedRaw(port string, output chan []byte) *BufferflowTimedRaw {
+func NewBufferflowTimedRaw(port string, output chan<- []byte) *BufferflowTimedRaw {
 	return &BufferflowTimedRaw{
 		port:              port,
 		output:            output,

hub.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"encoding/json"
+	"fmt"
 	"io"
 	"os"
 	"runtime"
@@ -84,10 +85,10 @@ func (h *hub) run() {
 		case c := <-h.register:
 			h.connections[c] = true
 			// send supported commands
-			c.send <- []byte("{\"Version\" : \"" + version + "\"} ")
+			c.send <- []byte(fmt.Sprintf(`{"Version" : "%s"} `, version))
 			c.send <- []byte(commands)
-			c.send <- []byte("{\"Hostname\" : \"" + *hostname + "\"} ")
-			c.send <- []byte("{\"OS\" : \"" + runtime.GOOS + "\"} ")
+			c.send <- []byte(fmt.Sprintf(`{"Hostname" : "%s"} `, *hostname))
+			c.send <- []byte(fmt.Sprintf(`{"OS" : "%s"} `, runtime.GOOS))
 		case c := <-h.unregister:
 			h.unregisterConnection(c)
 		case m := <-h.broadcast: