Renamed function for clarity

Author: cmaglie

main.go

@@ -153,15 +153,15 @@ func main() {
 	if src, err := os.Executable(); err != nil {
 		panic(err)
 	} else if strings.Contains(src, "-temp") {
-		newPath := updater.BinPath(src)
+		newPath := updater.RemoveTempSuffixFromPath(src)
 		if err := copyExe(src, newPath); err != nil {
 			log.Println("Copy error: ", err)
 			panic(err)
 		}
 		Systray.Update(newPath)
 	} else {
 		// Otherwise copy to a path with -temp suffix
-		if err := copyExe(src, updater.TempPath(src)); err != nil {
+		if err := copyExe(src, updater.AddTempSuffixToPath(src)); err != nil {
 			panic(err)
 		}
 		Systray.Start()

update.go

@@ -61,7 +61,7 @@ func updateHandler(c *gin.Context) {
 		return
 	}
 
-	path = updater.TempPath(path)
+	path = updater.AddTempSuffixToPath(path)
 
 	c.JSON(200, gin.H{"success": "Please wait a moment while the agent reboots itself"})
 	Systray.Update(path)

updater/updater.go

@@ -68,8 +68,8 @@ var errHashMismatch = errors.New("new file hash mismatch after patch")
 var errDiffURLUndefined = errors.New("DiffURL is not defined, I cannot fetch and apply patch, reverting to full bin")
 var up = update.New()
 
-// TempPath generates a temporary path for the executable (adding "-temp")
-func TempPath(path string) string {
+// AddTempSuffixToPath adds the "-temp" suffix to the path to an executable file (a ".exe" extension is replaced with "-temp.exe")
+func AddTempSuffixToPath(path string) string {
 	if filepath.Ext(path) == "exe" {
 		path = strings.Replace(path, ".exe", "-temp.exe", -1)
 	} else {
@@ -79,8 +79,8 @@ func TempPath(path string) string {
 	return path
 }
 
-// BinPath generates the proper path for a temporary executable (removing "-temp")
-func BinPath(path string) string {
+// RemoveTempSuffixFromPath removes "-temp" suffix from the path to an executable file (a "-temp.exe" extension is replaced with ".exe")
+func RemoveTempSuffixFromPath(path string) string {
 	return strings.Replace(path, "-temp", "", -1)
 }
 
@@ -234,7 +234,7 @@ func (u *Updater) update() error {
 		return err
 	}
 
-	path = TempPath(path)
+	path = AddTempSuffixToPath(path)
 
 	old, err := os.Open(path)
 	if err != nil {