Skip to content

Commit 80d6968

Browse files
author
Stefania
committed
fixed linting
1 parent fe382b3 commit 80d6968

File tree

4 files changed

+26
-24
lines changed

4 files changed

+26
-24
lines changed

demo/app.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const handleUpdateFirmware = (e, boardId, port, firmwareVersion) => {
6161
firmwareUpdater.updatingDone.subscribe(() => {
6262
console.log('Firmware updated successfully!');
6363
});
64-
64+
6565
firmwareUpdater.updatingError.subscribe(update => {
6666
console.log('Something went wrong when trying to update the firmware');
6767
console.error(update.err);
@@ -197,7 +197,7 @@ class App extends React.Component {
197197
close
198198
</a> - <a href="#" onClick={(e) => handleBootloaderMode(e, device.Name)}>
199199
bootloader mode
200-
</a> - <a href="#" onClick={(e) => handleUpdateFirmware(e, 'mkrwifi1010', device.Name, '1.0.0')}>
200+
</a> - <a href="#" onClick={(e) => handleUpdateFirmware(e, 'mkrwifi1010', device.Name, '1.2.1')}>
201201
MKR WiFi 1010 update firmware
202202
</a> - <a href="#" onClick={(e) => handleUpdateFirmware(e, 'mkr1000', device.Name, '19.4.4')}>
203203
MKR1000 update firmware

src/chrome-app-daemon.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
*/
2020

2121
import { interval } from 'rxjs';
22-
import { distinctUntilChanged, filter, startWith, takeUntil } from 'rxjs/operators';
22+
import {
23+
distinctUntilChanged, filter, startWith, takeUntil
24+
} from 'rxjs/operators';
2325

2426
import Daemon from './daemon';
2527

src/firmware-updater.js

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {BehaviorSubject} from 'rxjs';
1+
import { BehaviorSubject } from 'rxjs';
22

33
import {
44
takeUntil,
@@ -41,15 +41,15 @@ export default class FirmwareUpdater {
4141

4242
this.FWUToolStatus = FWUToolStatusEnum.NOPE;
4343
this.updating = new BehaviorSubject({ status: this.updateStatusEnum.NOPE });
44-
44+
4545
this.updatingDone = this.updating.pipe(filter(update => update.status === this.updateStatusEnum.DONE))
4646
.pipe(first())
4747
.pipe(takeUntil(this.updating.pipe(filter(update => update.status === this.updateStatusEnum.ERROR))));
48-
48+
4949
this.updatingError = this.updating.pipe(filter(update => update.status === this.updateStatusEnum.ERROR))
5050
.pipe(first())
5151
.pipe(takeUntil(this.updatingDone));
52-
52+
5353
this.gotFWInfo = this.updating.pipe(filter(update => update.status === this.updateStatusEnum.GOT_INFO))
5454
.pipe(first())
5555
.pipe(takeUntil(this.updatingDone))
@@ -64,14 +64,15 @@ export default class FirmwareUpdater {
6464
let firmwareInfoMessagesSubscription;
6565

6666
const handleFirmwareInfoMessage = message => {
67+
let versions;
6768
switch (message.ProgrammerStatus) {
6869
case 'Starting':
6970
break;
7071
case 'Busy':
7172
if (message.Msg.indexOf('Flashing with command:') >= 0) {
7273
return;
7374
}
74-
const versions = JSON.parse(message.Msg);
75+
versions = JSON.parse(message.Msg);
7576
Object.keys(versions).forEach(v => {
7677
if (versions[v][0].IsLoader) {
7778
this.loaderPath = versions[v][0].Path;
@@ -83,7 +84,6 @@ export default class FirmwareUpdater {
8384
this.firmwareVersionData = versionsList.find(version => version.Name.split(' ').splice(-1)[0].trim() === firmwareVersion);
8485
if (!this.firmwareVersionData) {
8586
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't get firmware info: couldn't find version '${firmwareVersion}' for board '${boardId}'` });
86-
return;
8787
}
8888
break;
8989
case 'Error':
@@ -97,8 +97,8 @@ export default class FirmwareUpdater {
9797
default:
9898
break;
9999
}
100-
}
101-
100+
};
101+
102102
if (this.FWUToolStatus !== FWUToolStatusEnum.OK) {
103103
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't get firmware info: couldn't find firmware updater tool` });
104104
return;
@@ -131,12 +131,12 @@ export default class FirmwareUpdater {
131131
}).then(response => {
132132
if (!response.ok) {
133133
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Error fetching ${this.Daemon.pluginURL}/upload` });
134-
return;
134+
135135
}
136-
}).catch(reason => {
136+
}).catch(() => {
137137
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Coudln't list firmware versions info.` });
138-
return ;
139-
});
138+
139+
});
140140
}
141141

142142
updateFirmware(boardId, port, firmwareVersion) {
@@ -147,28 +147,28 @@ export default class FirmwareUpdater {
147147
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't update Firmware: no port selected.` });
148148
return;
149149
}
150-
this.gotFWInfo.subscribe(state => {
150+
this.gotFWInfo.subscribe(() => {
151151
if (!this.firmwareVersionData) {
152152
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't update Firmware: couldn't find version '${firmwareVersion}' for board '${boardId}'` });
153153
return;
154154
}
155155

156156
let updateFirmwareMessagesSubscription;
157-
157+
158158
const handleFirmwareUpdateMessage = message => {
159159
switch (message.ProgrammerStatus) {
160160
case 'Error':
161-
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't update Firmware: ${message.Msg}`});
161+
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't update Firmware: ${message.Msg}` });
162162
updateFirmwareMessagesSubscription.unsubscribe();
163163
break;
164164
case 'Done':
165-
this.updating.next({ status: this.updateStatusEnum.DONE});
165+
this.updating.next({ status: this.updateStatusEnum.DONE });
166166
updateFirmwareMessagesSubscription.unsubscribe();
167167
break;
168168
default:
169169
break;
170170
}
171-
}
171+
};
172172

173173
updateFirmwareMessagesSubscription = this.Daemon.appMessages.subscribe(message => {
174174
if (message.ProgrammerStatus) {
@@ -181,7 +181,7 @@ export default class FirmwareUpdater {
181181
domain: 'arduino.cc',
182182
port: 443
183183
}];
184-
184+
185185
rootCertificates.forEach(address => {
186186
if (address.domain && address.port) {
187187
addresses += `-address ${address.domain}:${address.port} `;
@@ -221,11 +221,11 @@ export default class FirmwareUpdater {
221221
}).then(response => {
222222
if (!response.ok) {
223223
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't update Firmware: error fetching ${this.Daemon.pluginURL}/upload` });
224-
return;
224+
225225
}
226226
}).catch(reason => {
227227
this.updating.next({ status: this.updateStatusEnum.ERROR, err: `Can't update Firmware: ${reason}` });
228-
return;
228+
229229
});
230230
});
231231
this.getFirmwareInfo(boardId, port, firmwareVersion);

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ import FirmwareUpdater from './firmware-updater';
2525
const Daemon = window.navigator.userAgent.indexOf(' CrOS ') !== -1 ? ChromeOsDaemon : SocketDaemon;
2626

2727
export default Daemon;
28-
export {FirmwareUpdater};
28+
export { FirmwareUpdater };

0 commit comments

Comments
 (0)