Started ota file id path support

Author: rjtokenring

cli/ota/status.go

@@ -29,9 +29,10 @@ import (
 )
 
 type statusFlags struct {
-	otaID    string
-	deviceId string
-	wide     bool
+	otaID    		string
+	deviceId 		string
+	otaIdsFilePath  string
+	wide     	    bool
 }
 
 func initOtaStatusCommand() *cobra.Command {
@@ -49,20 +50,21 @@ func initOtaStatusCommand() *cobra.Command {
 	}
 	uploadCommand.Flags().StringVarP(&flags.otaID, "ota-id", "o", "", "OTA ID")
 	uploadCommand.Flags().StringVarP(&flags.deviceId, "device-id", "d", "", "Device ID")
+	uploadCommand.Flags().StringVarP(&flags.otaIdsFilePath, "ota-ids", "i", "", "OTA IDs file path. If set, the command will read the OTA IDs from the file and get the status for each OTA ID.")
 	uploadCommand.Flags().BoolVarP(&flags.wide, "wide", "w", false, "Show more status details")
 
 	return uploadCommand
 }
 
 func runOtaStatusCommand(flags *statusFlags) error {
-	if flags.otaID == "" && flags.deviceId == "" {
-		return fmt.Errorf("required flag(s) \"ota-id\" or \"device-id\" not set")
+	if flags.otaID == "" && flags.deviceId == "" && flags.otaIdsFilePath == "" {
+		return fmt.Errorf("required flag(s) \"ota-id\" or \"device-id\" or \"ota-ids\" not set")
 	}
 
 	cred, err := config.RetrieveCredentials()
 	if err != nil {
 		return fmt.Errorf("retrieving credentials: %w", err)
 	}
 
-	return ota.PrintOtaStatus(flags.otaID, flags.deviceId, flags.wide, cred)
+	return ota.PrintOtaStatus(flags.otaID, flags.deviceId, flags.otaIdsFilePath, flags.wide, cred)
 }

command/ota/status.go

@@ -11,7 +11,6 @@ import (
 func formatOutput(wideOutput bool, status any) {
 	if st, ok := status.(otaapi.Ota); ok {
 		if !wideOutput {
-			st.ID = ""
 			st.DeviceID = ""
 			st.ErrorReason = ""
 			st.Sha256 = ""
@@ -26,7 +25,6 @@ func formatOutputSlice(wideOutput bool, st []otaapi.Ota) {
 	}
 	for i := range st {
 		if !wideOutput {
-			st[i].ID = ""
 			st[i].DeviceID = ""
 			st[i].ErrorReason = ""
 			st[i].Sha256 = ""
@@ -42,22 +40,24 @@ func printJson(res any) {
 	}
 }
 
-func PrintOtaStatus(otaid, device string, wideOutput bool, cred *config.Credentials) error {
+func PrintOtaStatus(otaid, device, otaidpath string, wideOutput bool, cred *config.Credentials) error {
 	otapi := otaapi.NewClient(cred)
 
 	var err error
-	if otaid != "" {
+	if otaidpath != "" {
+	
+	} else if otaid != "" {
 		res, err := otapi.GetOtaStatusByOtaID(otaid)
 		if err == nil && res != nil {
 			formatOutput(wideOutput, res.Ota)
 		}
-	}
-	if device != "" {
+	} else if device != "" {
 		res, err := otapi.GetOtaStatusByDeviceID(device)
 		if err == nil && res != nil {
 			formatOutputSlice(wideOutput, res.Ota)
 		}
 	}
+
 	if err != nil {
 		return err
 	}