Skip to content

Commit 8dba78f

Browse files
committed
Improve output
1 parent 475f6a7 commit 8dba78f

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

cli/ota/upload.go

+10-15
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
package ota
1919

2020
import (
21-
"fmt"
2221
"os"
2322
"strings"
2423

@@ -78,22 +77,18 @@ func runUploadCommand(cmd *cobra.Command, args []string) {
7877
os.Exit(errorcodes.ErrGeneric)
7978
}
8079

81-
devs := strings.Join(resp.Updated, ",")
82-
devs = strings.TrimRight(devs, ",")
83-
success := fmt.Sprintf("Successfully sent OTA request to: %s", devs)
80+
success := strings.Join(resp.Updated, ",")
81+
success = strings.TrimRight(success, ",")
82+
feedback.Printf("\nSuccessfully sent OTA request to: %s", success)
8483

85-
devs = strings.Join(resp.Invalid, ",")
86-
devs = strings.TrimRight(devs, ",")
87-
invalid := fmt.Sprintf("Cannot send OTA request to: %s", devs)
84+
invalid := strings.Join(resp.Invalid, ",")
85+
invalid = strings.TrimRight(invalid, ",")
86+
feedback.Printf("Cannot send OTA request to: %s", invalid)
8887

89-
devs = strings.Join(resp.Failed, ",")
90-
devs = strings.TrimRight(devs, ",")
91-
fail := fmt.Sprintf("Failed to send OTA request to: %s", devs)
88+
fail := strings.Join(resp.Failed, ",")
89+
fail = strings.TrimRight(fail, ",")
90+
feedback.Printf("Failed to send OTA request to: %s", fail)
9291

9392
det := strings.Join(resp.Errors, "\n")
94-
det = strings.TrimRight(det, ",")
95-
details := fmt.Sprintf("\nDetails:\n%s", det)
96-
97-
feedback.Printf(success, invalid, fail, details)
98-
logrus.Info("Upload successfully started")
93+
feedback.Printf("\nDetails:\n%s", det)
9994
}

0 commit comments

Comments
 (0)