Check clone params before copying

polldo · polldo · commit 21378171c5c1 · 2021-08-06T11:41:11.000+02:00
diff --git a/command/thing/create.go b/command/thing/create.go
@@ -72,8 +72,12 @@ func cloneThing(client iot.Client, thingID string) (map[string]interface{}, erro
 	}
 
 	thing := make(map[string]interface{})
-	thing["device_id"] = clone.DeviceId
-	thing["properties"] = clone.Properties
+	if clone.DeviceId != "" {
+		thing["device_id"] = clone.DeviceId
+	}
+	if clone.Properties != nil {
+		thing["properties"] = clone.Properties
+	}
 
 	return thing, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,12 @@ func cloneThing(client iot.Client, thingID string) (map[string]interface{}, erro`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`thing := make(map[string]interface{})`
`75`		`- thing["device_id"] = clone.DeviceId`
`76`		`- thing["properties"] = clone.Properties`
	`75`	`+ if clone.DeviceId != "" {`
	`76`	`+ thing["device_id"] = clone.DeviceId`
	`77`	`+ }`
	`78`	`+ if clone.Properties != nil {`
	`79`	`+ thing["properties"] = clone.Properties`
	`80`	`+ }`
`77`	`81`
`78`	`82`	`return thing, nil`
`79`	`83`	`}`