Added unit tests

Author: rjtokenring

command/ota/encode.go

@@ -20,6 +20,7 @@ package ota
 import (
 	"fmt"
 	"os"
+	"strings"
 
 	"github.com/arduino/arduino-cloud-cli/internal/ota"
 )
@@ -42,7 +43,12 @@ func Encode(params *EncodeParams) (*string, error) {
 		return nil, fmt.Errorf("file %s contains a valid OTA header. Skip header encoding", params.File)
 	}
 
-	otaFile := fmt.Sprintf("%s.ota", params.File)
+	var otaFile string
+	if strings.HasSuffix(params.File, ".bin") {
+		otaFile = strings.Replace(params.File, ".bin", ".ota", 1)
+	} else {
+		otaFile = fmt.Sprintf("%s.ota", params.File)
+	}
 	_, err = os.Stat(otaFile)
 	if err == nil {
 		// file already exists, we need to delete it

internal/ota/decoder_test.go

@@ -0,0 +1,44 @@
+package ota
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestDecodeHeader(t *testing.T) {
+
+	header, err := DecodeOtaFirmwareHeader("testdata/cloud.ota")
+	assert.Nil(t, err)
+	assert.Equal(t, ArduinoVendorID, header.VID)
+	assert.Equal(t, "8057", header.PID)
+	assert.Equal(t, "arduino:samd:nano_33_iot", *header.FQBN)
+	assert.Equal(t, ArduinoFqbnToPID["arduino:samd:nano_33_iot"], header.PID)
+
+	header, err = DecodeOtaFirmwareHeader("testdata/blink.ota")
+	assert.Nil(t, err)
+	assert.Equal(t, ArduinoVendorID, header.VID)
+	assert.Equal(t, "8057", header.PID)
+	assert.Equal(t, "arduino:samd:nano_33_iot", *header.FQBN)
+	assert.Equal(t, ArduinoFqbnToPID["arduino:samd:nano_33_iot"], header.PID)
+
+}
+
+func TestDecodeWithNoHeader(t *testing.T) {
+
+	header, err := DecodeOtaFirmwareHeader("testdata/cloud.bin")
+	assert.Nil(t, header)
+	assert.NotNil(t, err)
+
+}
+
+func TestDecodeEsp32Header(t *testing.T) {
+
+	header, err := DecodeOtaFirmwareHeader("testdata/esp32.ota")
+	assert.Nil(t, err)
+	assert.Equal(t, Esp32MagicNumberPart1, header.VID)
+	assert.Equal(t, Esp32MagicNumberPart2, header.PID)
+	assert.Nil(t, header.FQBN)
+	assert.Equal(t, "ESP32", header.BoardType)
+
+}

internal/ota/encoder_test.go

@@ -20,7 +20,7 @@ package ota
 import (
 	"bytes"
 	"encoding/hex"
-	"io/ioutil"
+	"os"
 
 	"fmt"
 	"hash/crc32"
@@ -90,12 +90,12 @@ func TestEncodeFiles(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			input, err := ioutil.ReadFile(tt.infile)
+			input, err := os.ReadFile(tt.infile)
 			if err != nil {
 				t.Fatal("couldn't open test file")
 			}
 
-			want, err := ioutil.ReadFile(tt.outfile)
+			want, err := os.ReadFile(tt.outfile)
 			if err != nil {
 				t.Fatal("couldn't open test file")
 			}