Skip to content

Fixed codecov.yml file #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 1, 2020

For some reasons the changes in #727 have been ignored. Reading the codecov docs one possibility is that the file format is wrong, so I validated it with the webservice provided by codecov.

Before the patch:

$ curl --data-binary @.codecov.yml https://codecov.io/validate
Path: coverage->status->project->default->threshold
<shared.validation.helpers.PercentSchemaField object at 0x7f172d3e5a10>.validate(None) raised TypeError('expected string or bytes-like object')

After the patch:

$ curl --data-binary @.codecov.yml https://codecov.io/validate
Valid!

{
  "comment": false,
  "coverage": {
    "status": {
      "patch": false,
      "changes": false,
      "project": {
        "default": {
          "target": 30.0
        }
      }
    }
  }
}

Let's see if after this change the new configuration will get through...

The file has been validated with the webservice provided by codecov.

Before the patch:

$ curl --data-binary @.codecov.yml https://codecov.io/validate
Path: coverage->status->project->default->threshold
<shared.validation.helpers.PercentSchemaField object at 0x7f172d3e5a10>.validate(None) raised TypeError('expected string or bytes-like object')

After the patch:

$ curl --data-binary @.codecov.yml https://codecov.io/validate
Valid!

{
  "comment": false,
  "coverage": {
    "status": {
      "patch": false,
      "changes": false,
      "project": {
        "default": {
          "target": 30.0
        }
      }
    }
  }
}
@cmaglie cmaglie requested a review from rsora June 1, 2020 10:07
@cmaglie cmaglie merged commit 4b9c924 into arduino:master Jun 1, 2020
@cmaglie cmaglie deleted the fix-codecov-config branch June 1, 2020 14:02
@cmaglie cmaglie added this to the 0.11.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants