Skip to content

Fixed wrong IDE bundle-detection result caching #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

Fixed wrong IDE bundle-detection result caching #606

merged 1 commit into from
Apr 16, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 5, 2020

Previously the config value IDE.Bundled was set to false when it should be true:

arduino-cli/configuration/configuration.go

Lines 175 to 179 in d80f119

// Persist IDE-related config settings and return true
viper.Set("IDE.Bundled", false)
viper.Set("IDE.Directory", ideDir)
return true
}

Anyway IsBundledInDesktopIDE() return the wrong result only when it's called the second time and the cached value is returned without performing the check again.

This PR fixes this problem and simplify a bit the function.

@cmaglie cmaglie requested a review from masci March 5, 2020 14:59
@cmaglie cmaglie self-assigned this Mar 5, 2020
@rsora rsora added this to the 0.10.0 milestone Mar 19, 2020
@rsora rsora modified the milestones: 0.10.0, 0.11.0 Apr 14, 2020
@rsora rsora merged commit 8c5a8b2 into arduino:master Apr 16, 2020
rsora pushed a commit that referenced this pull request Apr 16, 2020
@cmaglie
Fixed wrong IDE bundle-detection result caching (#606)
b54c3c0
@cmaglie cmaglie deleted the fix-bundle-detection-caching branch April 24, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@masci masci Awaiting requested review from masci

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora