Avoid calling cloud API if vid or pid are invalid #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
reviewed
Oct 11, 2019
cmaglie
approved these changes
Oct 15, 2019
howjmay
pushed a commit
to howjmay/arduino-cli
that referenced
this pull request
Nov 13, 2019
* avoid calling cloud API if vid or pid are invalid * user regex
howjmay
pushed a commit
to howjmay/arduino-cli
that referenced
this pull request
Nov 13, 2019
* avoid calling cloud API if vid or pid are invalid * user regex
howjmay
pushed a commit
to howjmay/arduino-cli
that referenced
this pull request
Nov 13, 2019
* avoid calling cloud API if vid or pid are invalid * user regex
howjmay
pushed a commit
to howjmay/arduino-cli
that referenced
this pull request
Nov 13, 2019
* avoid calling cloud API if vid or pid are invalid * user regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the USB vid or pid are obviously wrong, avoid calling the API, sparing users' bandwidth and reducing useless pressure on the backend.
I moved vid/pid validation inside
apiByVidPidto keep theListlogic tidy and clean. A specific test case was added to cover the case vid or pid are invalid.