Skip to content

remove commands in favor of a new builder API #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

remove commands in favor of a new builder API #264

merged 1 commit into from
Jul 4, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Jul 4, 2019 •
edited
Loading

Start refactoring the legacy package by removing the Command pattern in favor of a more idiomatic functions API implemented in a new builder package. This PR starts by removing two commands:

  • GenerateBuildPathIfMissing
  • EnsureBuildPathExists

@masci masci marked this pull request as ready for review July 4, 2019 12:17
@masci masci merged commit 4a8523b into master Jul 4, 2019
@masci masci deleted the massi/refact branch July 4, 2019 14:09
mastrolinux pushed a commit that referenced this pull request Jul 16, 2019
@masci
remove commands in favor of a new builder API (#264)
a517dce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @cmaglie