Parallelize upload_mock integration tests
#2444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the output may be interleaved if tests are run in parallel.
cmaglie
added
type: enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2444 +/- ##
==========================================
- Coverage 67.38% 67.32% -0.07%
==========================================
Files 210 210
Lines 20591 20591
==========================================
- Hits 13876 13862 -14
- Misses 5578 5588 +10
- Partials 1137 1141 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Parallelize
upload_mockintegration test.Since the
upload_mocktests are the longest, this change should reduce the overall execution time, I didn't check accurately, but I'm pretty sure we are gaining at least a couple of minutes over the full CI process.What is the current behavior?
test-integration (windows-latest, upload_modk)completes in roughly ~12 minutes.What is the new behavior?
test-integration (windows-latest, upload_modk)completes in roughly ~8 minutes.Does this PR introduce a breaking change, and is titled accordingly?
Other information