Skip to content

[skip-changelog] builder: refactor utils functions #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 2, 2023
Merged

[skip-changelog] builder: refactor utils functions #2344

merged 8 commits into from
Oct 2, 2023

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Sep 26, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Moving some utils functions directly inside the builder

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (c506f6a) 63.04% compared to head (2496c45) 62.79%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   63.04%   62.79%   -0.25%     
==========================================
  Files         201      203       +2     
  Lines       19259    19143     -116     
==========================================
- Hits        12141    12021     -120     
- Misses       6064     6068       +4     
  Partials     1054     1054
Flag Coverage Δ
unit 62.79% <70.58%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
arduino/builder/core.go 71.18% <100.00%> (-2.66%) ⬇️
arduino/builder/internal/progress/progress.go 100.00% <100.00%> (ø)
arduino/builder/internal/utils/utils.go 70.86% <100.00%> (-3.78%) ⬇️
arduino/builder/libraries.go 79.82% <100.00%> (-1.43%) ⬇️
arduino/builder/sketch.go 62.28% <100.00%> (-0.97%) ⬇️
arduino/builder/linker.go 76.56% <75.00%> (-0.15%) ⬇️
arduino/builder/recipe.go 73.52% <50.00%> (-2.79%) ⬇️
arduino/builder/export_cmake.go 7.98% <0.00%> (ø)
arduino/builder/archive_compiled_files.go 61.53% <61.53%> (ø)
arduino/builder/sizer.go 47.29% <28.57%> (-0.31%) ⬇️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Sep 26, 2023
@alessio-perugini alessio-perugini self-assigned this Sep 26, 2023
@alessio-perugini alessio-perugini force-pushed the refactor-builder-archive branch 2 times, most recently from eb0cbab to ae0cd45 Compare September 26, 2023 17:29
@alessio-perugini alessio-perugini changed the title [skip-changelog] builder: move archiveCompiledFiles to builder struct [skip-changelog] builder: refactor utils functions Sep 26, 2023
@alessio-perugini alessio-perugini marked this pull request as ready for review September 26, 2023 17:36
@umbynos umbynos added this to the Arduino CLI v0.35.0 milestone Oct 2, 2023
cmaglie
cmaglie approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the missing License, LGTM 👍🏼

@alessio-perugini alessio-perugini force-pushed the refactor-builder-archive branch from e3754a9 to 6a33986 Compare October 2, 2023 15:11
@alessio-perugini alessio-perugini force-pushed the refactor-builder-archive branch from 6a33986 to 2496c45 Compare October 2, 2023 15:13
@alessio-perugini alessio-perugini merged commit f561da0 into master Oct 2, 2023
@alessio-perugini alessio-perugini deleted the refactor-builder-archive branch October 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@alessio-perugini alessio-perugini

Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
Arduino CLI v0.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-perugini @cmaglie @umbynos