Skip to content

Remove legacy "rewrite-rules" feature #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 29, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Removes the "rewrite-rules" feature, which is no more used nor documented.
It allowed us to not break compile on very old samd and avr platform releases, but it's useless today.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

cmaglie added 2 commits March 29, 2023 11:33
Previously the specific recipes to run CTags were added to global build
properties. Now the global build properties are not altered anymore and
the CTags-specific properties are created only to run CTags and dropped
afterward.
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 29, 2023
@cmaglie cmaglie self-assigned this Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 65.85% and project coverage change: -0.10 ⚠️

Comparison is base (5a67f3b) 62.62% compared to head (4146bd0) 62.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2132      +/-   ##
==========================================
- Coverage   62.62%   62.52%   -0.10%     
==========================================
  Files         231      227       -4     
  Lines       19610    19495     -115     
==========================================
- Hits        12281    12190      -91     
+ Misses       6229     6210      -19     
+ Partials     1100     1095       -5     
Flag Coverage Δ
unit 62.52% <65.85%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...egacy/builder/add_additional_entries_to_context.go 61.29% <ø> (-1.21%) ⬇️
legacy/builder/builder.go 90.62% <ø> (-0.15%) ⬇️
legacy/builder/container_setup.go 92.10% <ø> (-0.58%) ⬇️
legacy/builder/preprocess_sketch.go 0.00% <0.00%> (ø)
legacy/builder/types/context.go 97.53% <ø> (ø)
arduino/cores/packagemanager/package_manager.go 74.30% <100.00%> (+0.65%) ⬆️
legacy/builder/ctags_runner.go 78.04% <100.00%> (+1.73%) ⬆️
legacy/builder/gcc_preproc_runner.go 80.85% <100.00%> (+0.41%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit 5a1c2fe into arduino:master Mar 30, 2023
@cmaglie cmaglie deleted the remove-rewrite-rules-legacy branch March 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants