feat: filter boards by fqbn in connected list #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.50% // Head: 36.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
- Coverage 36.50% 36.48% -0.03%
==========================================
Files 228 228
Lines 19306 19343 +37
==========================================
+ Hits 7048 7057 +9
- Misses 11434 11461 +27
- Partials 824 825 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
per1234
added
type: enhancement
Bikappa
force-pushed
the
feat/board-list-fqbn-filter
branch
from
b6bdf64 to
12caaa8
Compare
Bikappa
force-pushed
the
feat/board-list-fqbn-filter
branch
2 times, most recently
from
117bbd3 to
74441de
Compare
per1234
requested changes
Jan 27, 2023
per1234
requested changes
Jan 27, 2023
Bikappa
force-pushed
the
feat/board-list-fqbn-filter
branch
from
c8dd36d to
e73a04d
Compare
per1234
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Ability to restrict the
board listoutput to the boards matching a specific FQBN.What is the current behavior?
When listing connected boards, all discovered boards are returned without user-controlled filtering
What is the new behavior?
The user can specify an FQBN parameter, the resulting list contains all and only the boards matching the given FQBN.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fixes #1068