diff --git a/docs/UPGRADING.md b/docs/UPGRADING.md index eb3f2766c98..b7b267ab1e1 100644 --- a/docs/UPGRADING.md +++ b/docs/UPGRADING.md @@ -4,6 +4,11 @@ Here you can find a list of migration guides to handle breaking changes between ## 0.30.0 +### `daemon` CLI command's `--ip` flag removal + +The `daemon` CLI command no longer allows to set a custom ip for the gRPC communication. Currently there is not enough +bandwith to support this feature. For this reason, the `--ip` flag has been removed. + ### `board attach` CLI command changed behaviour The `board attach` CLI command has changed behaviour: now it just pick whatever port and FQBN is passed as parameter and diff --git a/internal/cli/daemon/daemon.go b/internal/cli/daemon/daemon.go index 9536510ff8e..0a91e5125b5 100644 --- a/internal/cli/daemon/daemon.go +++ b/internal/cli/daemon/daemon.go @@ -39,7 +39,6 @@ import ( var ( tr = i18n.Tr - ip string daemonize bool debug bool debugFile string @@ -56,7 +55,6 @@ func NewCommand() *cobra.Command { Args: cobra.NoArgs, Run: runDaemonCommand, } - daemonCommand.PersistentFlags().StringVar(&ip, "ip", "127.0.0.1", tr("The IP address the daemon will listen to")) daemonCommand.PersistentFlags().String("port", "", tr("The TCP port the daemon will listen to")) configuration.Settings.BindPFlag("daemon.port", daemonCommand.PersistentFlags().Lookup("port")) daemonCommand.Flags().BoolVar(&daemonize, "daemonize", false, tr("Do not terminate daemon process if the parent process dies")) @@ -120,6 +118,7 @@ func runDaemonCommand(cmd *cobra.Command, args []string) { go feedback.ExitWhenParentProcessEnds() } + ip := "127.0.0.1" lis, err := net.Listen("tcp", fmt.Sprintf("%s:%s", ip, port)) if err != nil { // Invalid port, such as "Foo"