Skip to content

Include platform bundled libs when -b flag is used #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Include platform bundled libs when -b flag is used #2000

merged 2 commits into from
Dec 21, 2022

Conversation

MatteoPologruto
Copy link
Contributor

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Code enhancement

What is the current behavior?

Platform bundled libraries are not shown when -b flag is used. It is necessary to set the --all flag with it.

C:\Users\m.pologruto>arduino-cli lib list -b esp32:esp32:esp32 ArduinoOTA
No libraries installed.

C:\Users\m.pologruto>arduino-cli lib list -b esp32:esp32:esp32 ArduinoOTA --all
Name       Installed       Available     Location          Description
ArduinoOTA 1.0             1.0.8         esp32:[email protected] Enables Over The Air upgrades, via wi...

What is the new behavior?

To show the bundled libraries, the --all flag is automatically set when the -b flag is used.

C:\Users\m.pologruto> ./arduino-cli lib list -b esp32:esp32:esp32 ArduinoOTA
Name       Installed       Available     Location          Description
ArduinoOTA 1.0             1.0.8         esp32:[email protected] Enables Over The Air upgrades, via wi...

Does this PR introduce a breaking change, and is titled accordingly?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself criticality: medium Of moderate impact labels Dec 5, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 5, 2022
@MatteoPologruto MatteoPologruto merged commit 357d465 into arduino:master Dec 21, 2022
@MatteoPologruto MatteoPologruto deleted the bundled-lib-list branch December 21, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

@MatteoPologruto MatteoPologruto

Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatteoPologruto @umbynos