From eb3a58ee93b5545b015f0a4c1e1647fec0aba12f Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 10 Oct 2022 07:17:58 -0700 Subject: [PATCH] Disable "fail fast" feature in "Test Go" workflow To ensure functionality on all platforms, the "Test Go" GitHub Actions workflow runs the tests on Windows, Linux, and macOS. This is done via a "job matrix", which runs the three jobs in parallel. By default GitHub Actions uses a "fail fast" behavior for job matrixes, where all in progress or pending jobs of the matrix are immediately canceled upon failure of any job. The benefit of this "fail fast" behavior is efficiency in the case where a failure is universal and those other jobs were certain to eventually fail. However, in other cases a failure is either specific to the configuration of a single job (e.g., a Windows-specific bug), or a spurious result of a transient network outage. In the latter case, canceling the other jobs is very harmful. Running the jobs for the other operating systems would highlight the nature of an OS-specific failure for the contributor. Canceling other jobs due to a transient failure means all those jobs must be reran instead of only the specific job that suffered the failure. The workflow is hereby configured to disable the "fail fast" behavior. All the matrix jobs will now run even if one of them has failed. --- .github/workflows/test-go-task.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-go-task.yml b/.github/workflows/test-go-task.yml index 90df72399eb..d8266519e59 100644 --- a/.github/workflows/test-go-task.yml +++ b/.github/workflows/test-go-task.yml @@ -62,6 +62,8 @@ jobs: if: needs.run-determination.outputs.result == 'true' strategy: + fail-fast: false + matrix: operating-system: - ubuntu-latest