[skip-changelog] Migrate tests from `test_compile_part_3.py` to `compile_part_3_test.go` #1906

MatteoPologruto · 2022-10-05T09:52:34Z

Please check if the PR fulfills these requirements

The PR has no duplicates (please search among the Pull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure Enhancement

What is the new behavior?

This PR is a followup to PR #1806
Integration tests that were previously present in test_compile_part_3.py have been rewritten in compile_part_3_test.go, without changing their original purpose.
More informations on the tests can be found checking the single commits.

Does this PR introduce a breaking change, and is titled accordingly?

No

codecov · 2022-10-05T10:13:42Z

Codecov Report

Base: 36.84% // Head: 0.00% // Decreases project coverage by -36.84% ⚠️

Coverage data is based on head (08d25b5) compared to base (fb9d4a8).
Patch has no changes to coverable lines.

❗ Current head 08d25b5 differs from pull request most recent head 8a8df2b. Consider uploading reports for the commit 8a8df2b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #1906       +/-   ##
==========================================
- Coverage   36.84%       0   -36.85%     
==========================================
  Files         235       0      -235     
  Lines       19763       0    -19763     
==========================================
- Hits         7282       0     -7282     
+ Misses      11650       0    -11650     
+ Partials      831       0      -831

Flag	Coverage Δ
unit	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/integrationtest/arduino-cli.go
legacy/builder/builder.go
...der/wipeout_build_path_if_build_options_changed.go
commands/lib/utils.go
executils/null.go
arduino/security/signatures.go
commands/upgrade/upgrade.go
cli/generatedocs/generatedocs.go
configuration/defaults.go
legacy/builder/container_setup.go
... and 225 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/integrationtest/compile/compile_part_3_test.go

internal/integrationtest/testdata/boards.local.txt

internal/integrationtest/compile/compile_part_3_test.go

umbynos

Left some notes

MatteoPologruto · 2022-10-11T09:11:15Z

I've rearranged some tests following PR #1913. I left the ones that are not using arduino:avr as a core and the ones that are modifying either boards.local.txt or platform.local.txt in compile_part_3_test.go.

internal/integrationtest/compile/compile_part_1_test.go

… to compile_part_3_test.go

…_3.py to compile_part_3_test.go

…y to compile_part_3_test.go A new function that sets the working directory to a specific path has been added in order to run all the tests as intended.

…part_3.py to compile_part_3_test.go

…to compile_part_3_test.go

… compile_part_3_test.go

….py to compile_part_3_test.go

…m test_compile_part_3.py to compile_part_3_test.go

….go and delete test_compile_part_3.py

umbynos

MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 5, 2022

MatteoPologruto self-assigned this Oct 5, 2022

MatteoPologruto force-pushed the compile-3 branch from c878887 to 14d1467 Compare October 5, 2022 10:18

MatteoPologruto marked this pull request as ready for review October 5, 2022 10:23

MatteoPologruto requested review from cmaglie and umbynos October 5, 2022 10:23

umbynos reviewed Oct 6, 2022

View reviewed changes

internal/integrationtest/compile/compile_part_3_test.go Outdated Show resolved Hide resolved

umbynos reviewed Oct 6, 2022

View reviewed changes

internal/integrationtest/testdata/boards.local.txt Show resolved Hide resolved

umbynos reviewed Oct 6, 2022

View reviewed changes

internal/integrationtest/compile/compile_part_3_test.go Outdated Show resolved Hide resolved

umbynos suggested changes Oct 6, 2022

View reviewed changes

MatteoPologruto force-pushed the compile-3 branch 3 times, most recently from 39a83d1 to 686ff3e Compare October 11, 2022 08:02

MatteoPologruto requested a review from umbynos October 11, 2022 09:11

MatteoPologruto force-pushed the compile-3 branch from 686ff3e to 08d25b5 Compare October 12, 2022 12:06

umbynos reviewed Oct 13, 2022

View reviewed changes

internal/integrationtest/compile/compile_part_1_test.go Show resolved Hide resolved

MatteoPologruto added 10 commits October 13, 2022 15:10

Migrate TestCompileSketchWithPdeExtension from test_compile_part_3.py…

b31ea08

… to compile_part_3_test.go

Migrate TestCompileSketchWithMultipleMainFiles from test_compile_part…

6482686

…_3.py to compile_part_3_test.go

Migrate TestCompileSketchCaseMismatchFails from test_compile_part_3.p…

821a746

…y to compile_part_3_test.go A new function that sets the working directory to a specific path has been added in order to run all the tests as intended.

Migrate TestCompileWithOnlyCompilationDatabaseFlag from test_compile_…

16b29e5

…part_3.py to compile_part_3_test.go

Migrate TestCompileUsingPlatformLocalTxt from test_compile_part_3.py …

33dd1e0

…to compile_part_3_test.go

Migrate TestCompileUsingBoardsLocalTxt from test_compile_part_3.py to…

1a9f90c

… compile_part_3_test.go

Migrate TestCompileManuallyInstalledPlatform from test_compile_part_3…

0983d63

….py to compile_part_3_test.go

Migrate TestCompileManuallyInstalledPlatformUsingPlatformLocalTxt fro…

f620c28

…m test_compile_part_3.py to compile_part_3_test.go

Migrate TestCompileWithFullyPrecompiledLibrary to compile_part_3_test…

885aa40

….go and delete test_compile_part_3.py

Rearrange tests to have them share the same environment

8a8df2b

MatteoPologruto force-pushed the compile-3 branch from 08d25b5 to 8a8df2b Compare October 13, 2022 13:34

umbynos approved these changes Oct 13, 2022

View reviewed changes

MatteoPologruto merged commit c48844b into arduino:master Oct 13, 2022

MatteoPologruto deleted the compile-3 branch October 13, 2022 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[skip-changelog] Migrate tests from `test_compile_part_3.py` to `compile_part_3_test.go` #1906

[skip-changelog] Migrate tests from `test_compile_part_3.py` to `compile_part_3_test.go` #1906

MatteoPologruto commented Oct 5, 2022

codecov bot commented Oct 5, 2022 •

edited

Loading

umbynos left a comment

MatteoPologruto commented Oct 11, 2022 •

edited

Loading

umbynos left a comment

[skip-changelog] Migrate tests from test_compile_part_3.py to compile_part_3_test.go #1906

[skip-changelog] Migrate tests from test_compile_part_3.py to compile_part_3_test.go #1906

Conversation

MatteoPologruto commented Oct 5, 2022

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

codecov bot commented Oct 5, 2022 • edited Loading

Codecov Report

umbynos left a comment

Choose a reason for hiding this comment

MatteoPologruto commented Oct 11, 2022 • edited Loading

umbynos left a comment

Choose a reason for hiding this comment

[skip-changelog] Migrate tests from `test_compile_part_3.py` to `compile_part_3_test.go` #1906

[skip-changelog] Migrate tests from `test_compile_part_3.py` to `compile_part_3_test.go` #1906

codecov bot commented Oct 5, 2022 •

edited

Loading

MatteoPologruto commented Oct 11, 2022 •

edited

Loading