Bugfix: do not overwrite board properties during compile #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
changed the title
cmaglie
added
priority: high
cmaglie
force-pushed
the
fix_1614
branch
3 times, most recently
from
bdabf46 to
b1f304e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
- Coverage 35.53% 35.50% -0.04%
==========================================
Files 231 230 -1
Lines 19543 19532 -11
==========================================
- Hits 6945 6934 -11
Misses 11773 11773
Partials 825 825
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
matthijskooijman
approved these changes
Aug 1, 2022
umbynos
approved these changes
Aug 2, 2022
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fix a weird behavior of the Arduino CLI when running as a daemon: the board options seem to get "stuck" after the first compile: if a second compile is run with different options then these will be ignored and the options used on the first run are used.
The options used on the first compile cannot be changed. See Unique property definitions from previous compilations for other custom board options persist #1614 for an example
The options are handled correctly.
No
Fix Unique property definitions from previous compilations for other custom board options persist #1614
The tests for the PR has been prepared as part of the new grpc testsuite here: