Skip to content

Apply some updates from dependabot #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 9, 2019
Merged

Apply some updates from dependabot #125

merged 8 commits into from
Jan 9, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 9, 2019

We could not use directly the PRs from dependabot because he's trying to add some modules of arduino-cli as a dependency of the project itself (for example as in https://github.com/arduino/arduino-cli/pull/110/files#diff-bd247e83efc3c45ae9e8c47233249f18R25): this makes the coverage test to fail.

Also it would be nice to have the vendor directory updated as well. I don't know if this is going to be added anytime soon... probably the best thing to do is migrate from dep to go.mod since this is now the standard way to manage dependencies.

/cc @dependabot

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-35-PR125-linux64.tar.bz2

⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-35-PR125-linux32.tar.bz2

⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-35-PR125-linuxarm.tar.bz2

⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-35-PR125-windows.zip

⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-35-PR125-osx.zip

ℹ️ To test this build:

  1. Just replace arduino-cli binary with the provided one

@cmaglie cmaglie added this to the next alpha preview milestone Jan 9, 2019
@cmaglie cmaglie merged commit 02ffe3c into arduino:master Jan 9, 2019
@cmaglie cmaglie deleted the updates branch January 9, 2019 11:02
per1234 added a commit that referenced this pull request Aug 9, 2021
@per1234
Merge pull request #125 from arduino/per1234/check-to-rule
439c93d 
Use "rule" term instead of "check"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.4-alpha.preview
Development

Successfully merging this pull request may close these issues.
3 participants
@cmaglie @CLAassistant @ArduinoBot