Fix gRPC interface function to merge configs #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds the possibility to set empty values with the Merge gRPC function, previously they would have been ignored. Because of this change I had also to modify the GetValue() function since it would first check if the value was set using the Viper.InConfig() function that wouldn't check for values set with Viper.Set().
cmaglie
approved these changes
Feb 2, 2021
silvanocerza
added a commit
that referenced
this pull request
Feb 4, 2021
* Fix gRPC interface function to merge configs This fix adds the possibility to set empty values with the Merge gRPC function, previously they would have been ignored. Because of this change I had also to modify the GetValue() function since it would first check if the value was set using the Viper.InConfig() function that wouldn't check for values set with Viper.Set(). * [skip changelog] Add clearer example to client_example * [skip changelog] Simplified some code and enhance a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Bug fix.
Calling the gRPC interface Merge function to merge existing configs with new ones would ignored empty values.
This fix adds the possibility to set empty values with the Merge gRPC function, previously they would have been ignored.
Because of this change I had also to modify the GetValue() function since it would first check if the value was set using the Viper.InConfig() function that wouldn't check for values set with Viper.Set().
No.
Fixes #1161
See how to contribute